ICU ios build #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramezgerges
force-pushed
the
macos-ios-build
branch
9 times, most recently
from
b044730 to
41af62b
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the ICU build system to support iOS and macOS platforms in addition to the existing WebAssembly support. The changes add comprehensive build workflows for creating ICU libraries for iOS (device and simulator) and macOS, along with the necessary NuGet packaging configuration.
- Adds build workflows for ICU libraries targeting iOS device, iOS simulator, and macOS platforms
- Creates new NuGet packages for iOS and macOS ICU distributions
- Restructures the existing WASM package organization and removes platform-specific conditions
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/main.yml | Adds comprehensive build jobs for macOS and iOS ICU libraries with universal binary creation |
| nuget/uno.icu-ios/uno.icu-ios.nuspec | Defines NuGet package specification for iOS ICU libraries |
| nuget/uno.icu-ios/buildTransitive/Uno.icu-ios.targets | MSBuild targets for iOS native library references with simulator/device detection |
| nuget/uno.icu-macos/uno.icu-macos.nuspec | Defines NuGet package specification for macOS ICU libraries |
| nuget/uno.icu-wasm/buildTransitive/Uno.icu-wasm.targets | Creates new WASM-specific build targets file |
| nuget/uno.icu-wasm/build/Uno.icu-wasm.targets | Removes WebAssembly-specific condition from embedded resource inclusion |
| nuget/buildTransitive/Uno.icu-wasm.targets | Removes the original transitive targets file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jeromelaban
approved these changes
Oct 14, 2025
Member
jeromelaban
left a comment
jeromelaban
left a comment
There was a problem hiding this comment.
aside from copilot's comments, looks good
ramezgerges
force-pushed
the
macos-ios-build
branch
from
d2b2c88 to
fb0144e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend on #4