Skip to content

Conversation

@ramezgerges
Copy link
Contributor

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@ramezgerges ramezgerges force-pushed the macos-build branch 3 times, most recently from c4da891 to 89d2248 Compare October 3, 2025 17:48
@ramezgerges ramezgerges force-pushed the macos-build branch 4 times, most recently from 51effc1 to fb22ed9 Compare October 4, 2025 17:00
@ramezgerges ramezgerges force-pushed the macos-build branch 2 times, most recently from 7fc1fb9 to 9763112 Compare October 4, 2025 17:32
@ramezgerges ramezgerges mentioned this pull request Oct 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds macOS support to the Uno ICU library by creating a new uno.icu-macos NuGet package and updating the build process to compile ICU libraries for macOS platforms.

  • Adds build jobs for creating universal macOS ICU binaries (x86_64 and arm64)
  • Creates new uno.icu-macos NuGet package specification for macOS ICU libraries
  • Restructures the existing build process to support multiple target platforms

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.github/workflows/main.yml Adds macOS build jobs and restructures artifact handling to support both WASM and macOS targets
nuget/uno.icu-macos/uno.icu-macos.nuspec Creates NuGet package specification for macOS ICU libraries
nuget/uno.icu-wasm/buildTransitive/Uno.icu-wasm.targets Adds MSBuild targets for WASM native file references
nuget/uno.icu-wasm/build/Uno.icu-wasm.targets Removes WebAssembly-specific condition from embedded resource inclusion
nuget/buildTransitive/Uno.icu-wasm.targets Removes old build targets file (moved to package-specific location)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from copilot's comments, looks good

Copy link

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM but I lack context. Is this only for web assembly on macOS ?

@ramezgerges
Copy link
Contributor Author

@spouliot No, it's for the desktop target. I'm working on a new text handling implementation that is Unicode-aware, which uses ICU for stuff like line segmentation and BiDi, so we need a package that provides the ICU binaries.

@ramezgerges ramezgerges merged commit 7c67e92 into main Oct 19, 2025
12 of 13 checks passed
@ramezgerges ramezgerges deleted the macos-build branch October 19, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants