-
Notifications
You must be signed in to change notification settings - Fork 612
fix: ui inconsistencies #5167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: ui inconsistencies #5167
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
fd48e63
fix: ui inconsistencies
ogzhanolguncu 4b10d44
fix: aniamtions
ogzhanolguncu 48fbf1d
feat: finalize deployment steps page
ogzhanolguncu b98c769
fix: missing deployentId case
ogzhanolguncu 45c6cb7
refactor: file locations
ogzhanolguncu 6104fe4
feat: add final step to onboarding
ogzhanolguncu 28e3ab1
fix: skeletons
ogzhanolguncu 6817f84
feat: add deployment info to onboarding
ogzhanolguncu cd3ddb9
refactor: show deployment at last onboarding step
ogzhanolguncu c7bee00
feat: use the same active deployment card everywhere
ogzhanolguncu aae69a5
fix: minor spacing issues according to the lastest design
ogzhanolguncu 2544fce
fix: give some depth to icons
ogzhanolguncu a0b86f2
fix: ui inconsistencies
ogzhanolguncu 8168daa
feat: add repo icons
ogzhanolguncu 0c145ef
chore: fmt
ogzhanolguncu 70ada90
fix: ctrl-worker manifest
ogzhanolguncu 0770b4c
feat: add auto redirect
ogzhanolguncu 8d8e8d2
fix: ui and flow issues
ogzhanolguncu 310c5df
fix: ui issues continues
ogzhanolguncu b37dd30
fix: deployment list issues
ogzhanolguncu 46ef5ab
fix: deployment list spacings
ogzhanolguncu 895f9a8
feat: add virtualization to reposelect
ogzhanolguncu 4587866
refactor: make consistent colors
ogzhanolguncu d60503b
[autofix.ci] apply automated fixes
autofix-ci[bot] 7da4b91
[autofix.ci] apply automated fixes (attempt 2/3)
autofix-ci[bot] 22d7817
fix: nextjs serverside param fetch issue
ogzhanolguncu 0f9faa1
fix: dont let user come back
ogzhanolguncu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
...ments/[deploymentId]/(deployment-progress)/build-steps-table/build-step-logs-expanded.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import { TimestampInfo } from "@unkey/ui"; | ||
| import { Fragment } from "react/jsx-runtime"; | ||
| import type { BuildStepRow } from "./columns"; | ||
|
|
||
| export function BuildStepLogsExpanded({ step }: { step: BuildStepRow }) { | ||
| if (!step.logs || step.logs.length === 0) { | ||
| return ( | ||
| <tr> | ||
| <td colSpan={6} className="px-8 py-4 text-sm text-gray-9"> | ||
| No logs available for this step | ||
| </td> | ||
| </tr> | ||
| ); | ||
| } | ||
|
|
||
| return ( | ||
| <> | ||
| <tr> | ||
| <td className="border-l-2 border-accent-7 p-0" /> | ||
| </tr> | ||
| {step.logs.map((log, idx) => ( | ||
| <Fragment key={`row-group-${log.time}-${idx}`}> | ||
| <tr key={`spacer-${log.time}-${idx}`} style={{ height: "4px" }}> | ||
| <td className="border-l-2 border-accent-7 p-0" /> | ||
| </tr> | ||
ogzhanolguncu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <tr key={`${log.time}-${idx}`}> | ||
| <td className="border-l-2 border-accent-7 py-0" /> | ||
| <td className="py-0"> | ||
| <TimestampInfo | ||
| displayType="local_hours_with_millis" | ||
| value={log.time} | ||
| className="font-mono text-xs text-grayA-9 hover:underline decoration-dotted" | ||
| /> | ||
| </td> | ||
| <td className="py-0" /> | ||
| <td colSpan={3} className="h-[26px] py-[1px]"> | ||
| <span className="whitespace-pre-wrap font-mono text-xs text-gray-12 break-all"> | ||
| {log.message} | ||
| </span> | ||
| </td> | ||
| </tr> | ||
| </Fragment> | ||
| ))} | ||
| </> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...s/table/utils/get-build-step-row-class.ts → ...gress)/build-steps-table/get-row-class.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
...verview)/deployments/[deploymentId]/(deployment-progress)/build-steps-table/skeletons.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| export const StartedAtColumnSkeleton = () => ( | ||
| <div className="h-3 w-16 bg-grayA-3 rounded animate-pulse" /> | ||
| ); | ||
|
|
||
| export const StatusColumnSkeleton = () => ( | ||
| <div className="size-4 bg-grayA-3 rounded-full animate-pulse" /> | ||
| ); | ||
|
|
||
| export const NameColumnSkeleton = () => ( | ||
| <div className="h-3 w-[500px] bg-grayA-3 rounded animate-pulse" /> | ||
| ); | ||
|
|
||
| export const DurationColumnSkeleton = () => ( | ||
| <div className="h-3 w-14 bg-grayA-3 rounded animate-pulse" /> | ||
| ); |
67 changes: 67 additions & 0 deletions
67
...rojectId]/(overview)/deployments/[deploymentId]/(deployment-progress)/deployment-info.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| "use client"; | ||
|
|
||
| import { formatCpuParts, formatMemoryParts } from "@/lib/utils/deployment-formatters"; | ||
| import { Bolt, Cloud, Grid, LayoutRight } from "@unkey/icons"; | ||
| import { Button, InfoTooltip } from "@unkey/ui"; | ||
| import { ActiveDeploymentCard } from "../../../../components/active-deployment-card"; | ||
| import { DeploymentStatusBadge } from "../../../../components/deployment-status-badge"; | ||
| import { InfoChip } from "../../../../components/info-chip"; | ||
| import { RegionFlags } from "../../../../components/region-flags"; | ||
| import { Section, SectionHeader } from "../../../../components/section"; | ||
| import { useOptionalProjectLayout } from "../../../layout-provider"; | ||
| import { useDeployment } from "../layout-provider"; | ||
|
|
||
| export function DeploymentInfo({ title = "Deployment" }: { title?: string }) { | ||
| const { deployment } = useDeployment(); | ||
| const projectLayout = useOptionalProjectLayout(); | ||
| const deploymentStatus = deployment.status; | ||
|
|
||
| return ( | ||
| <Section> | ||
| <SectionHeader icon={<Cloud iconSize="md-regular" className="text-gray-9" />} title={title} /> | ||
| <ActiveDeploymentCard | ||
| deploymentId={deployment.id} | ||
| trailingContent={ | ||
| <div className="flex gap-1.5 items-center"> | ||
| <div className="2xl:flex gap-1.5 items-center hidden"> | ||
| <InfoChip icon={Bolt}> | ||
| <div className="text-xs flex gap-0.5"> | ||
| <span className="font-medium text-gray-12"> | ||
| {formatCpuParts(deployment.cpuMillicores).value} | ||
| </span> | ||
| <span className="text-gray-11"> | ||
| {formatCpuParts(deployment.cpuMillicores).unit} | ||
| </span> | ||
| </div> | ||
| </InfoChip> | ||
| <InfoChip icon={Grid}> | ||
| <div className="text-xs flex gap-0.5"> | ||
| <span className="font-medium text-gray-12"> | ||
| {formatMemoryParts(deployment.memoryMib).value} | ||
| </span> | ||
| <span className="text-gray-11"> | ||
| {formatMemoryParts(deployment.memoryMib).unit} | ||
| </span> | ||
| </div> | ||
| </InfoChip> | ||
| </div> | ||
| <RegionFlags instances={deployment.instances} /> | ||
| {projectLayout && ( | ||
| <InfoTooltip asChild content="Show deployment details"> | ||
| <Button | ||
| variant="ghost" | ||
| className="[&_svg]:size-3 size-3 rounded-sm" | ||
| size="icon" | ||
| onClick={() => projectLayout.setIsDetailsOpen(!projectLayout.isDetailsOpen)} | ||
ogzhanolguncu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| > | ||
| <LayoutRight iconSize="sm-regular" className="text-gray-10" /> | ||
| </Button> | ||
| </InfoTooltip> | ||
| )} | ||
| </div> | ||
| } | ||
| statusBadge={<DeploymentStatusBadge status={deploymentStatus} />} | ||
| /> | ||
| </Section> | ||
| ); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.