Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Mar 2, 2026
Merged
Merged
Contributor
Author
19 tasks
Contributor
📝 WalkthroughWalkthroughInfrastructure configuration and dashboard UI refactoring for deployment management. Adds GitHub App credential configuration in Kubernetes manifests, restructures deployment progress and information components, introduces skeleton loaders and expanded log views, updates column sizing in tables, adds multiple new language icons and utilities, and extends onboarding flows with virtualization and deployment tracking. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DeploymentProgress
participant DeploymentLiveStep
participant DeploymentService
participant Router
User->>DeploymentProgress: View deployment progress
DeploymentProgress->>DeploymentService: Query build steps & network status
DeploymentService-->>DeploymentProgress: Return progress data
DeploymentProgress->>DeploymentProgress: Monitor network completion
alt Network Not Ready
DeploymentProgress->>User: Display DeploymentProgress component
User->>User: View step indicators
else Network Ready
DeploymentProgress->>DeploymentLiveStep: Navigate with deploymentId
DeploymentLiveStep->>DeploymentService: Check deployment ready state
DeploymentService-->>DeploymentLiveStep: Return ready status
DeploymentLiveStep->>DeploymentLiveStep: Start 15s countdown timer
User->>User: View countdown
DeploymentLiveStep->>Router: Auto-navigate to deployment overview (on countdown=0)
Router-->>User: Display deployment page
end
sequenceDiagram
participant User
participant OnboardingWizard
participant GitHubCheck
participant ConfigureDeployment
participant DeploymentMonitor
participant Router
User->>OnboardingWizard: Start onboarding
OnboardingWizard->>OnboardingWizard: Render Create Project step
User->>OnboardingWizard: Proceed
OnboardingWizard->>OnboardingWizard: Render Select Repository step
User->>OnboardingWizard: Choose repository
OnboardingWizard->>GitHubCheck: Check hasInstallations
GitHubCheck-->>OnboardingWizard: Installation status
alt No GitHub Installation
OnboardingWizard->>User: Show Connect GitHub step
User->>User: Authorize app
end
OnboardingWizard->>ConfigureDeployment: Render Configure Deployment step
User->>ConfigureDeployment: Create deployment
ConfigureDeployment->>DeploymentMonitor: Trigger onDeploymentCreated callback
DeploymentMonitor->>OnboardingWizard: Advance wizard to Deploying
OnboardingWizard->>DeploymentMonitor: Render DeploymentLiveStep with deploymentId
DeploymentMonitor->>Router: Auto-redirect on ready
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
19 tasks
ogzhanolguncu
requested review from
Flo4604,
MichaelUnkey,
chronark,
imeyer,
mcstepp and
perkinsjr
as code owners
ogzhanolguncu
force-pushed
the
improve-deployment-page
branch
from
af7d63e to
6093231
Compare
ogzhanolguncu
force-pushed
the
trigger-deploy
branch
from
d508da6 to
33266fb
Compare
ogzhanolguncu
force-pushed
the
trigger-deploy
branch
from
33266fb to
e7ff4b4
Compare
ogzhanolguncu
force-pushed
the
improve-deployment-page
branch
from
83f6cea to
80aa9da
Compare
ogzhanolguncu
force-pushed
the
improve-deployment-page
branch
from
80aa9da to
f594f77
Compare
ogzhanolguncu
force-pushed
the
trigger-deploy
branch
from
e7ff4b4 to
d71bdc2
Compare
ogzhanolguncu
force-pushed
the
improve-deployment-page
branch
from
f594f77 to
f2a0604
Compare
ogzhanolguncu
force-pushed
the
trigger-deploy
branch
from
d71bdc2 to
74e31cf
Compare
ogzhanolguncu
force-pushed
the
improve-deployment-page
branch
from
6c05450 to
22d7817
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 14
🧹 Nitpick comments (4)
web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/settings/components/shared/settings-group.tsx (1)
30-48: Empty button rendered whenhideChevronis true.When
hideChevronistrue, the button is still rendered but contains no content. This creates an invisible clickable element that:
- Still toggles the expanded state on click
- Has hover styles applied to empty space
- Presents an accessibility concern (screen readers announce an empty button)
If the intent is to fully disable collapse/expand functionality, consider hiding the button entirely. Alternatively, if only the visual toggle indicator should be hidden while keeping the section permanently expanded, you may want to skip rendering the button and lock
expandedtotrue.♻️ Suggested fix: conditionally render the button
- <button - type="button" - onClick={() => setExpanded((prev) => !prev)} - className="flex items-center gap-1 text-xs text-gray-10 hover:text-gray-11 transition-colors group duration-300" - > - {!hideChevron && ( - <> - {expanded ? "Hide" : "Show"} - <ChevronRight - className="text-gray-10 group-hover:text-gray-11 transition-all duration-300 flex-shrink-0" - iconSize="sm-medium" - style={{ - transitionTimingFunction: "cubic-bezier(.62,.16,.13,1.01)", - transform: expanded ? "rotate(270deg)" : "rotate(90deg)", - }} - /> - </> - )} - </button> + {!hideChevron && ( + <button + type="button" + onClick={() => setExpanded((prev) => !prev)} + className="flex items-center gap-1 text-xs text-gray-10 hover:text-gray-11 transition-colors group duration-300" + > + {expanded ? "Hide" : "Show"} + <ChevronRight + className="text-gray-10 group-hover:text-gray-11 transition-all duration-300 flex-shrink-0" + iconSize="sm-medium" + style={{ + transitionTimingFunction: "cubic-bezier(.62,.16,.13,1.01)", + transform: expanded ? "rotate(270deg)" : "rotate(90deg)", + }} + /> + </button> + )}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/apps/dashboard/app/`(app)/[workspaceSlug]/projects/[projectId]/(overview)/settings/components/shared/settings-group.tsx around lines 30 - 48, The button currently renders even when hideChevron is true which creates an empty, interactive element; change the JSX to conditionally render the entire button only when !hideChevron (so remove the <button> including onClick and children when hideChevron is true) and, if the intended behavior is to lock the section open when hideChevron is true, ensure the expanded state (expanded/setExpanded) is set to true by default or forced when hideChevron is true; also ensure accessibility by keeping or adding aria-expanded on the rendered button to reflect the expanded state (references: hideChevron, expanded, setExpanded, ChevronRight).web/apps/dashboard/tailwind.config.js (2)
4-4: Unused import.This import has no effect—
tailwindcss/pluginis imported for side effects only but nothing is bound. If you intended to use the plugin API, bind it (e.g.,import plugin from "tailwindcss/plugin"); otherwise, remove this line.Suggested fix
-import "tailwindcss/plugin";🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/apps/dashboard/tailwind.config.js` at line 4, Remove the no-op side-effect import of "tailwindcss/plugin" or convert it to a bound import if you plan to use the plugin API; specifically either delete the line import "tailwindcss/plugin" from the tailwind.config.js, or change it to a bound import (e.g., import plugin from "tailwindcss/plugin") and then reference the plugin identifier when registering plugins in the configuration.
157-172:mergemutates its first argument and mishandlesnull.Two concerns:
In-place mutation:
merge(defaultTheme.theme, {...})mutates the importeddefaultTheme.themeobject. If the module is cached and reused elsewhere, this could cause subtle cross-contamination. Consider cloningobj1before merging or using a non-mutating approach.
nullhandling:typeof null === "object"in JavaScript, sonullvalues inobj2enter the object-merge branch and are silently ignored instead of overwriting.For a Tailwind config that runs once at build time, the practical risk is low—this is a recommended cleanup rather than a blocker.
Non-mutating alternative
-export function merge(obj1, obj2) { - for (const key in obj2) { - // biome-ignore lint/suspicious/noPrototypeBuiltins: don't tell me what to do - if (obj2.hasOwnProperty(key)) { - if (typeof obj2[key] === "object" && !Array.isArray(obj2[key])) { - if (!obj1[key]) { - obj1[key] = {}; - } - obj1[key] = merge(obj1[key], obj2[key]); - } else { - obj1[key] = obj2[key]; - } - } - } - return obj1; -} +export function merge(obj1, obj2) { + const result = { ...obj1 }; + for (const key in obj2) { + if (Object.hasOwn(obj2, key)) { + const val = obj2[key]; + if (val !== null && typeof val === "object" && !Array.isArray(val)) { + result[key] = merge(result[key] ?? {}, val); + } else { + result[key] = val; + } + } + } + return result; +}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/apps/dashboard/tailwind.config.js` around lines 157 - 172, The merge function mutates its first argument and treats null as an object; update merge(obj1, obj2) to be non-mutating (create a cloned result from obj1, e.g., a shallow or deep clone before merging) and change the recursive branch to only recurse when obj2[key] is a non-null object (e.g., obj2[key] !== null && typeof obj2[key] === "object" && !Array.isArray(obj2[key])); ensure arrays and null values in obj2 overwrite the result rather than being recursed into, and return the new merged object instead of modifying obj1.web/internal/icons/src/icons/lang-php.tsx (1)
46-49: Consider using camelCase for SVG attributes.The
stop-colorattribute should bestopColorin React/JSX for consistency with React's DOM property naming conventions. While browsers handle kebab-case SVG attributes, React prefers camelCase.Suggested fix
- <stop stop-color="#AEB2D5" /> - <stop offset=".3" stop-color="#AEB2D5" /> - <stop offset=".75" stop-color="#484C89" /> - <stop offset="1" stop-color="#484C89" /> + <stop stopColor="#AEB2D5" /> + <stop offset=".3" stopColor="#AEB2D5" /> + <stop offset=".75" stopColor="#484C89" /> + <stop offset="1" stopColor="#484C89" />🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/internal/icons/src/icons/lang-php.tsx` around lines 46 - 49, In the lang-php.tsx SVG, replace kebab-case SVG props on the <stop> elements (e.g., "stop-color") with React/JSX camelCase props ("stopColor") so the <stop ... /> elements use stopColor attributes; update every occurrence in the SVG fragment inside the LangPhp component or exported JSX to ensure consistency with React DOM property naming conventions.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@dev/k8s/manifests/ctrl-worker.yaml`:
- Around line 51-56: Change the GitHub secrets in the Kubernetes manifest to be
required by setting optional: false for the env entries that provide
UNKEY_GITHUB_APP_ID / UNKEY_GITHUB_PRIVATE_KEY_PEM /
UNKEY_ALLOW_UNAUTHENTICATED_DEPLOYMENTS so os.ExpandEnv does not leave "${VAR}"
literals in the TOML, and then prevent a nil deref by either adding a nil guard
before accessing cfg.GitHub.AllowUnauthenticatedDeployments (e.g., if cfg.GitHub
!= nil && cfg.GitHub.AllowUnauthenticatedDeployments ...) or by enforcing
presence of cfg.GitHub in Config.Validate() (reject config when GitHub section
is missing); update the manifest and validation logic accordingly so startup
cannot hit a nil pointer or TOML parse errors.
In `@web/apps/dashboard/app/`(app)/[workspaceSlug]/layout.tsx:
- Line 15: Replace the visible typo in the loading paragraph text inside the
layout component: locate the JSX paragraph element with className "text-sm
text-gray-600 dark:text-gray-400" that currently reads "Lasdasdoading
workspace..." and change the copy to the intended user-facing string (e.g.,
"Loading workspace...") so the UI shows the correct message.
In
`@web/apps/dashboard/app/`(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(deployment-progress)/build-steps-table/build-step-logs-expanded.tsx:
- Around line 18-25: The spacer rows only render a single <td> in a table that
has six columns, causing layout issues; update both spacer rows (the standalone
one before the map and the per-log spacer inside the step.logs.map in
build-step-logs-expanded.tsx) to render a single <td> with colSpan set to the
full column count (e.g., colSpan={6}) and preserve the existing classes/style so
the spacer visually matches other rows.
In
`@web/apps/dashboard/app/`(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(deployment-progress)/build-steps-table/deployment-build-steps-table.tsx:
- Around line 39-43: The first-skeleton cell's left padding is being cancelled
because column.cellClassName (e.g., the expand column's "p-0") is appended after
the conditional "pl-[18px]"; change the class composition so the desired padding
wins — either move the idx === 0 ? "pl-[18px]" conditional to be appended after
column.cellClassName, or apply an explicit override like "!pl-[18px]" when idx
=== 0; update the className construction in the component that uses cn(...)
(referencing cn, className, idx, and column.cellClassName) so the first cell
keeps its left padding.
In
`@web/apps/dashboard/app/`(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(deployment-progress)/deployment-info.tsx:
- Around line 51-55: The icon-only Button used for toggling details (onClick
calls projectLayout.setIsDetailsOpen and reads projectLayout.isDetailsOpen)
lacks an accessible name and has a tiny hit target; add an explicit accessible
label (e.g., aria-label or aria-pressed that reflects the current state like
"Open details" / "Close details") and increase the clickable area by changing
the sizing classes (remove or replace the small "size-3" class and/or add
padding such as "p-2" or a larger size class so the hit target meets touch
guidelines) while keeping the existing onClick logic intact.
In
`@web/apps/dashboard/app/`(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(deployment-progress)/deployment-progress.tsx:
- Around line 30-37: The buildSteps query is currently polling full step logs
every second (trpc.deploy.deployment.buildSteps.useQuery with includeStepLogs:
true and refetchInterval: 1000); change polling to request metadata-only (set
includeStepLogs: false) and either increase refetchInterval to a sane value
(e.g., 10s) or remove polling, and implement a separate on-demand query (e.g.,
buildStepLogs or same buildSteps with includeStepLogs: true) that is triggered
when a step is expanded to fetch logs. Update any UI expansion handler to call
the new on-demand query and keep the polling query limited to metadata by
referencing the same deploymentId parameter.
- Around line 17-19: Do not force-cast route params; instead remove the `as
string` casts on `workspaceSlug` and `projectId`, validate that `params`
contains those keys, and handle the missing case explicitly (e.g., call Next.js
notFound()/redirect() or render an error/loader) before using the values. Update
the code around `params`, `workspaceSlug`, and `projectId` to derive typed
values only after checking they are present (throw/return early or invoke
notFound/redirect) so subsequent URL construction uses guaranteed strings rather
than unsafe casts.
In
`@web/apps/dashboard/app/`(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(deployment-progress)/deployment-step.tsx:
- Line 73: The JSX currently treats duration as falsy so a zero value is hidden;
update the conditional in the span that renders the duration (the JSX containing
duration and the ms() call) to use a null/undefined check (e.g., check duration
!= null or duration !== null && duration !== undefined) instead of a truthy
check so that duration = 0 renders as ms(0).
In `@web/apps/dashboard/app/`(app)/[workspaceSlug]/projects/onboarding/index.tsx:
- Line 30: The install-query condition currently treats a falsy/undefined
installationData as resolved which causes the "connect-github" step to mount and
then disappear; update the trpc.github.hasInstallations.useQuery call to
destructure the loading state (e.g., const { data: installationData, isLoading }
= trpc.github.hasInstallations.useQuery()) and only render or include the
"connect-github" step when the query is finished and data indicates the
appropriate state (e.g., !isLoading && installationData !== undefined && /* your
existing check */). Apply the same pattern to other checks in the file that rely
on installationData (the block around lines 51-70) so steps are not
mounted/removed while the query is loading.
- Around line 103-107: The deploying StepWizard.Step currently renders null when
projectId or deploymentId are missing; change the render branch inside the
StepWizard.Step with id="deploying" so it shows a non-empty fallback UI instead
of null (for example a centered message, placeholder card, and/or a Spinner with
a retry button) whenever projectId or deploymentId are falsy; keep the existing
happy-path that renders DeploymentLiveStep(projectId, deploymentId) and ensure
the fallback references the same props/state names (projectId, deploymentId) so
users aren’t left with a blank screen if deployment state is lost.
In `@web/apps/dashboard/components/virtual-table/index.tsx`:
- Around line 399-400: The expanded content returned by renderExpanded
(renderExpanded?.(typedItem)) can produce non-<tr> nodes directly under <tbody>;
change the rendering so that whenever isExpanded and renderExpanded produces
content you wrap it in a table row and cell: renderExpanded?.(typedItem) should
be placed inside <tr><td colSpan={columns.length}>...</td></tr> (use the
existing columns array length for colSpan), ensuring this replacement is applied
wherever renderExpanded?.(typedItem) is rendered (the blocks that reference
isExpanded and renderExpanded), or alternatively narrow the renderExpanded type
to only accept a function that returns a table row element.
In `@web/internal/icons/src/icons/lang-elixir.tsx`:
- Around line 23-24: The SVG attributes in the JSX of lang-elixir.tsx are using
hyphenated names (e.g., stop-color, stop-opacity, fill-rule, clip-rule,
fill-opacity) which trigger React warnings; update every hyphenated SVG
attribute in the component's JSX to their camelCase equivalents (stopColor,
stopOpacity, fillRule, clipRule, fillOpacity) — e.g., in all <stop .../> and
<path .../> elements inside the exported component (the SVG/React component in
this file), replace each hyphenated prop with the camelCase name and verify the
JSX/TSX compiles cleanly.
In `@web/internal/icons/src/icons/lang-go.tsx`:
- Around line 14-19: Change the SVG attribute names to React JSX camelCase:
replace the fill-rule attributes on the <g> element and the <path> with fillRule
(e.g., update the fill-rule="evenodd" on the <g> and fill-rule="nonzero" on the
<path>), ensuring you edit the SVG markup inside the lang-go component (the <g>
and corresponding <path> elements) in icons/lang-go.tsx so they use fillRule
instead of fill-rule.
In `@web/internal/icons/src/icons/lang-python.tsx`:
- Around line 23-24: In lang-python.tsx update the SVG <stop> attributes to use
React camelCase names: replace any occurrences of stop-color and stop-opacity on
the <stop> elements with stopColor and stopOpacity respectively (look for the
<stop ... /> elements in the component) so the JSX uses valid React attribute
names.
---
Nitpick comments:
In
`@web/apps/dashboard/app/`(app)/[workspaceSlug]/projects/[projectId]/(overview)/settings/components/shared/settings-group.tsx:
- Around line 30-48: The button currently renders even when hideChevron is true
which creates an empty, interactive element; change the JSX to conditionally
render the entire button only when !hideChevron (so remove the <button>
including onClick and children when hideChevron is true) and, if the intended
behavior is to lock the section open when hideChevron is true, ensure the
expanded state (expanded/setExpanded) is set to true by default or forced when
hideChevron is true; also ensure accessibility by keeping or adding
aria-expanded on the rendered button to reflect the expanded state (references:
hideChevron, expanded, setExpanded, ChevronRight).
In `@web/apps/dashboard/tailwind.config.js`:
- Line 4: Remove the no-op side-effect import of "tailwindcss/plugin" or convert
it to a bound import if you plan to use the plugin API; specifically either
delete the line import "tailwindcss/plugin" from the tailwind.config.js, or
change it to a bound import (e.g., import plugin from "tailwindcss/plugin") and
then reference the plugin identifier when registering plugins in the
configuration.
- Around line 157-172: The merge function mutates its first argument and treats
null as an object; update merge(obj1, obj2) to be non-mutating (create a cloned
result from obj1, e.g., a shallow or deep clone before merging) and change the
recursive branch to only recurse when obj2[key] is a non-null object (e.g.,
obj2[key] !== null && typeof obj2[key] === "object" &&
!Array.isArray(obj2[key])); ensure arrays and null values in obj2 overwrite the
result rather than being recursed into, and return the new merged object instead
of modifying obj1.
In `@web/internal/icons/src/icons/lang-php.tsx`:
- Around line 46-49: In the lang-php.tsx SVG, replace kebab-case SVG props on
the <stop> elements (e.g., "stop-color") with React/JSX camelCase props
("stopColor") so the <stop ... /> elements use stopColor attributes; update
every occurrence in the SVG fragment inside the LangPhp component or exported
JSX to ensure consistency with React DOM property naming conventions.
ℹ️ Review info
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (72)
dev/k8s/manifests/ctrl-worker.yamlweb/apps/dashboard/app/(app)/[workspaceSlug]/layout.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/components/card.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(deployment-progress)/build-steps-table/build-step-logs-expanded.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(deployment-progress)/build-steps-table/columns.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(deployment-progress)/build-steps-table/deployment-build-steps-table.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(deployment-progress)/build-steps-table/get-row-class.tsweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(deployment-progress)/build-steps-table/skeletons.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(deployment-progress)/deployment-info.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(deployment-progress)/deployment-progress.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(deployment-progress)/deployment-step.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(overview)/components/metrics/metric-card.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(overview)/components/sections/deployment-domains-section.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(overview)/components/sections/deployment-info-section.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(overview)/components/sections/deployment-network-section.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(overview)/components/table/build-step-logs-expanded.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(overview)/components/table/hooks/use-deployment-build-steps-query.tsweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/layout-provider.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/network/deployment-network-view.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/network/unkey-flow/components/nodes/components/card-footer.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/network/unkey-flow/components/nodes/components/metric-pill.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/network/unkey-flow/components/overlay/node-details-panel/region-node/sentinel-instances.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/page.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/components/table/components/actions/components/deployment-card.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/components/table/deployments-list.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/details/project-details-expandables/sections.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/layout-provider.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/navigations/use-breadcrumb-config.tsweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/openapi-diff/page.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/settings/components/runtime-settings/cpu.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/settings/components/runtime-settings/memory.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/settings/components/runtime-settings/storage.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/settings/components/shared/settings-group.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/components/active-deployment-card/components/skeleton.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/components/active-deployment-card/index.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/components/deployment-domains-card.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/components/project-content-wrapper.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/components/section.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/page.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/_components/list/projects-card-skeleton.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/_components/list/projects-card.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/onboarding/index.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/onboarding/onboarding-step-header.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/onboarding/steps/configure-deployment.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/onboarding/steps/deployment-live.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/onboarding/steps/select-repo/index.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/onboarding/steps/select-repo/language-icon.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/onboarding/steps/select-repo/repo-list-item.tsxweb/apps/dashboard/app/(app)/[workspaceSlug]/projects/onboarding/steps/select-repo/skeleton.tsxweb/apps/dashboard/app/(app)/integrations/github/callback/page.tsxweb/apps/dashboard/components/loading-state.tsxweb/apps/dashboard/components/stats-card/index.tsxweb/apps/dashboard/components/virtual-table/constants.tsweb/apps/dashboard/components/virtual-table/index.tsxweb/apps/dashboard/components/virtual-table/types.tsweb/apps/dashboard/lib/github.tsweb/apps/dashboard/lib/trpc/routers/github.tsweb/apps/dashboard/lib/utils/deployment-formatters.tsweb/apps/dashboard/tailwind.config.jsweb/internal/icons/src/icons/hammer-2.tsxweb/internal/icons/src/icons/lang-elixir.tsxweb/internal/icons/src/icons/lang-go.tsxweb/internal/icons/src/icons/lang-java.tsxweb/internal/icons/src/icons/lang-javascript.tsxweb/internal/icons/src/icons/lang-php.tsxweb/internal/icons/src/icons/lang-python.tsxweb/internal/icons/src/icons/lang-ruby.tsxweb/internal/icons/src/icons/lang-rust.tsxweb/internal/icons/src/icons/lang-typescript.tsxweb/internal/icons/src/icons/layer-front.tsxweb/internal/icons/src/index.tsweb/internal/ui/src/components/settings-card.tsx
💤 Files with no reviewable changes (5)
- web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(overview)/components/sections/deployment-domains-section.tsx
- web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(overview)/components/sections/deployment-info-section.tsx
- web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(overview)/components/table/hooks/use-deployment-build-steps-query.ts
- web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(overview)/components/table/build-step-logs-expanded.tsx
- web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/navigations/use-breadcrumb-config.ts
...loyments/[deploymentId]/(deployment-progress)/build-steps-table/build-step-logs-expanded.tsx
Show resolved
Hide resolved
...ents/[deploymentId]/(deployment-progress)/build-steps-table/deployment-build-steps-table.tsx
Show resolved
Hide resolved
.../[projectId]/(overview)/deployments/[deploymentId]/(deployment-progress)/deployment-info.tsx
Show resolved
Hide resolved
web/apps/dashboard/app/(app)/[workspaceSlug]/projects/onboarding/index.tsx
Show resolved
Hide resolved
perkinsjr
reviewed
Mar 3, 2026
perkinsjr
requested changes
Mar 3, 2026
Member
perkinsjr
left a comment
perkinsjr
left a comment
There was a problem hiding this comment.
I saw a spelling mistake on the loader.
Functionally it works
perkinsjr
approved these changes
Mar 3, 2026
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements a comprehensive redesign of the deployment progress experience and enhances GitHub integration for the onboarding flow.
Type of change
Key Changes
Deployment Progress Redesign
GitHub Integration Enhancements
UI/UX Improvements
Infrastructure Updates
How should this be tested?
Checklist
Required
pnpm buildpnpm fmtmake fmton/godirectoryconsole.logsgit pull origin mainAppreciated