Skip to content

feat: gateways get created on k8s#4375

Merged
chronark merged 7 commits intomainfrom
11-20-feat_gateways_get_created_on_k8s
Nov 26, 2025
Merged

feat: gateways get created on k8s#4375
chronark merged 7 commits intomainfrom
11-20-feat_gateways_get_created_on_k8s

Conversation

@chronark
Copy link
Collaborator

@chronark chronark commented Nov 20, 2025

What does this PR do?

This PR enhances the Kubernetes backend implementation for deployments and gateways with several improvements:

  1. Adds namespace safety handling by extracting namespace variables and using consistent safeIDForK8s function
  2. Adds namespace creation capability when creating gateways
  3. Updates RBAC permissions to allow namespace management and deployment resources
  4. Adds gateway_config field to environment database schema
  5. Fixes label selectors in gateway services to use correct unkey.gateway.id instead of unkey.deployment.id
  6. Updates k8s manifests to support Docker build backend with socket mounting
  7. Configures local development environment with proper volume mounts and settings

Fixes #(issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test creating a new environment and verify the gateway_config field is properly populated
  • Test creating a gateway in a non-existent namespace and verify it creates the namespace automatically
  • Test gateway creation and verify the service selector uses the correct label
  • Test deployment operations with the updated namespace handling

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Ran make fmt on /go directory
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

@vercel
Copy link

vercel bot commented Nov 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
dashboard Ready Ready Preview Comment Nov 26, 2025 2:00pm
engineering Ready Ready Preview Comment Nov 26, 2025 2:00pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025

⚠️ No Changeset found

Latest commit: 5090220

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 11-20-feat_gateways_get_created_on_k8s

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator Author

chronark commented Nov 20, 2025

@vercel vercel bot temporarily deployed to Preview – engineering November 20, 2025 12:33 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard November 20, 2025 12:33 Inactive
Base automatically changed from 11-19-feat_gateways_get_created_on_project_init to main November 26, 2025 13:51
@vercel vercel bot temporarily deployed to Preview – engineering November 26, 2025 14:00 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard November 26, 2025 14:00 Inactive
@chronark chronark marked this pull request as ready for review November 26, 2025 14:03
@chronark chronark merged commit 1427233 into main Nov 26, 2025
20 checks passed
@chronark chronark deleted the 11-20-feat_gateways_get_created_on_k8s branch November 26, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant