Skip to content

Testing megs changes trigger#4212

Closed
ogzhanolguncu wants to merge 3 commits intomainfrom
testing-megs-changes-trigger
Closed

Testing megs changes trigger#4212
ogzhanolguncu wants to merge 3 commits intomainfrom
testing-megs-changes-trigger

Conversation

@ogzhanolguncu
Copy link
Contributor

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2025

⚠️ No Changeset found

Latest commit: 4087888

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
dashboard Ignored Ignored Preview Nov 3, 2025 0:33am
engineering Ignored Ignored Preview Nov 3, 2025 0:33am

@vercel vercel bot temporarily deployed to Preview – engineering November 3, 2025 12:30 Inactive
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 3, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

GitHub Actions workflows updated for improved path filtering and dashboard testing automation. Path detection filters restructured using negated glob patterns for Go and expanded for dashboard dependencies. New dashboard test workflow added. Minor UI component styling adjustment and audit logs service constant updated.

Changes

Cohort / File(s) Change Summary
GitHub Actions Workflow Configuration
.github/workflows/job_detect_changes.yaml, .github/workflows/job_test_dashboard.yaml, .github/workflows/pr.yaml
Updated path filter patterns using negated globs for Go directories (go/!(benchmarks|demo_api)/**); expanded dashboard dependencies to include internal packages (billing, clickhouse, db, encryption, events, hash, id, keys, proto, schema, ui, icons, resend); added new dashboard test job with Node setup and pnpm turbo test/build steps; refactored workflow conditions with parenthesized grouping for PR/non-PR branches.
Dashboard Component
apps/dashboard/components/confirmation-popover.tsx
Increased default popover minimum width from 344px to 345px in DEFAULT_POPOVER_PROPS.className.
Audit Logs Service
go/internal/services/auditlogs/insert.go
Updated DEFAULT_BUCKET constant from "unkey_mutations" to "unkey_mutations_s".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

  • Verify negated glob patterns in job_detect_changes.yaml correctly match intended paths and exclude benchmarks/demo_api
  • Confirm environment variables configured in job_test_dashboard.yaml (database, workspace, API, WorkOS credentials) are correct and accessible
  • Review workflow condition logic refactoring in pr.yaml to ensure parenthesized grouping evaluates as intended

Possibly related PRs

  • #3176: Modifies detect_changes workflow and pr.yaml gating logic with extended path filters and dashboard job integration
  • #3078: Related to dashboard testing workflow configuration and dashboard path detection

Suggested labels

🕹️ oss.gg, :joystick: 150 points

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch testing-megs-changes-trigger

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4b32cc5 and 4087888.

📒 Files selected for processing (5)
  • .github/workflows/job_detect_changes.yaml (2 hunks)
  • .github/workflows/job_test_dashboard.yaml (1 hunks)
  • .github/workflows/pr.yaml (1 hunks)
  • apps/dashboard/components/confirmation-popover.tsx (1 hunks)
  • go/internal/services/auditlogs/insert.go (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ogzhanolguncu ogzhanolguncu marked this pull request as ready for review November 3, 2025 12:31
@vercel vercel bot temporarily deployed to Preview – dashboard November 3, 2025 12:32 Inactive
@ogzhanolguncu ogzhanolguncu requested a review from imeyer as a code owner November 3, 2025 12:33
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Here is an example:

<type>[optional scope]: <description>
fix: I fixed something for Unkey

Details:

No release type found in pull request title "Testing megs changes trigger". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@ogzhanolguncu ogzhanolguncu deleted the testing-megs-changes-trigger branch November 3, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants