Skip to content

feat: add dashboard changes for new key credits#4199

Closed
Flo4604 wants to merge 3 commits intofeat/identity-credits-workflowfrom
feat/identity-credits-dashboard
Closed

feat: add dashboard changes for new key credits#4199
Flo4604 wants to merge 3 commits intofeat/identity-credits-workflowfrom
feat/identity-credits-dashboard

Conversation

@Flo4604
Copy link
Member

@Flo4604 Flo4604 commented Oct 28, 2025

What does this PR do?

This adds the changes for the new credits schema into the dashboard.

When creating new keys we use the new schema, when we already have data in the new schema we will update it.
If the remaining data is in the keys table we will keep working with it.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

Make sure that new keys (credits data in credits table) and old keys (credits data in keys table) continue to work.
this means updating any of those keys updates in the correct table and does not error out.

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

@vercel
Copy link

vercel bot commented Oct 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
dashboard Ready Ready Preview Comment Nov 4, 2025 5:16pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
engineering Ignored Ignored Preview Nov 4, 2025 5:16pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2025

⚠️ No Changeset found

Latest commit: 357c868

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/identity-credits-dashboard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member Author

Flo4604 commented Oct 28, 2025

@vercel vercel bot temporarily deployed to Preview – engineering October 28, 2025 22:25 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard October 28, 2025 22:28 Inactive
@Flo4604 Flo4604 force-pushed the feat/identity-credits-workflow branch from 68ae12d to 8097e24 Compare October 28, 2025 22:40
@Flo4604 Flo4604 force-pushed the feat/identity-credits-dashboard branch from 3f165ab to a2a31aa Compare October 28, 2025 22:40
@vercel vercel bot temporarily deployed to Preview – engineering October 28, 2025 22:41 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard October 28, 2025 22:41 Inactive
@Flo4604 Flo4604 force-pushed the feat/identity-credits-workflow branch from 8097e24 to a5ab7f7 Compare October 29, 2025 09:51
@Flo4604 Flo4604 force-pushed the feat/identity-credits-dashboard branch from a2a31aa to 6b11039 Compare October 29, 2025 09:51
@vercel vercel bot temporarily deployed to Preview – engineering October 29, 2025 09:52 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard October 29, 2025 09:52 Inactive
@Flo4604 Flo4604 force-pushed the feat/identity-credits-dashboard branch from 6b11039 to ae55b72 Compare October 29, 2025 09:59
@Flo4604 Flo4604 force-pushed the feat/identity-credits-workflow branch from a5ab7f7 to 7ee37d0 Compare October 29, 2025 09:59
@vercel vercel bot temporarily deployed to Preview – dashboard October 29, 2025 09:59 Inactive
@vercel vercel bot temporarily deployed to Preview – engineering October 29, 2025 09:59 Inactive
@Flo4604 Flo4604 force-pushed the feat/identity-credits-workflow branch from 7ee37d0 to 1e83d32 Compare October 29, 2025 10:14
@Flo4604 Flo4604 force-pushed the feat/identity-credits-dashboard branch from ae55b72 to 9658a61 Compare October 29, 2025 10:14
@vercel vercel bot temporarily deployed to Preview – engineering October 29, 2025 10:15 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard October 29, 2025 10:15 Inactive
@Flo4604 Flo4604 force-pushed the feat/identity-credits-workflow branch from 1e83d32 to 1470c15 Compare October 29, 2025 10:21
@Flo4604 Flo4604 force-pushed the feat/identity-credits-dashboard branch from 9658a61 to 07b1b0b Compare October 29, 2025 10:21
@vercel vercel bot temporarily deployed to Preview – engineering October 29, 2025 10:22 Inactive
@Flo4604 Flo4604 force-pushed the feat/identity-credits-dashboard branch from 616a1d8 to bb27dc5 Compare October 30, 2025 13:48
@Flo4604 Flo4604 force-pushed the feat/identity-credits-workflow branch from 4f072a6 to 5d3d6f6 Compare October 30, 2025 13:48
@vercel vercel bot temporarily deployed to Preview – engineering October 30, 2025 13:49 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard October 30, 2025 13:49 Inactive
@Flo4604 Flo4604 force-pushed the feat/identity-credits-dashboard branch from bb27dc5 to 7489178 Compare October 30, 2025 15:08
@Flo4604 Flo4604 force-pushed the feat/identity-credits-workflow branch from 5d3d6f6 to 922ec04 Compare October 30, 2025 15:08
@vercel vercel bot temporarily deployed to Preview – engineering October 30, 2025 15:09 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard October 30, 2025 15:09 Inactive
@Flo4604 Flo4604 force-pushed the feat/identity-credits-workflow branch from 922ec04 to 3856684 Compare October 30, 2025 15:12
@Flo4604 Flo4604 force-pushed the feat/identity-credits-dashboard branch from 7489178 to 3663b1f Compare October 30, 2025 15:12
@vercel vercel bot temporarily deployed to Preview – engineering October 30, 2025 15:13 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard October 30, 2025 15:13 Inactive
@Flo4604 Flo4604 force-pushed the feat/identity-credits-dashboard branch from 3663b1f to 37e4a27 Compare October 30, 2025 16:30
@vercel vercel bot temporarily deployed to Preview – engineering October 30, 2025 16:30 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard October 30, 2025 16:30 Inactive
@Flo4604 Flo4604 marked this pull request as ready for review October 30, 2025 16:42
@Flo4604
Copy link
Member Author

Flo4604 commented Oct 30, 2025

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Flo4604 Flo4604 force-pushed the feat/identity-credits-dashboard branch from 37e4a27 to 07a5ea2 Compare October 30, 2025 17:00
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

@ogzhanolguncu ogzhanolguncu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

cr_54GfW9gmz1PRP71U ws_54GWEo21eEdds19H key_54GfVv82PZtZiJCA NULL 1000 5 20 NULL 1762178302587 1762178302587

DB changes are not reflecting to UI form correctly

Are we going to update credit form too? If not in this PR let's create a sub issue for this.

Copy link
Member Author

Flo4604 commented Nov 3, 2025

no, should be done in this pr

Copy link
Member Author

Flo4604 commented Nov 3, 2025

must be a bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants