chore: deleting dead code (kv package)

[chronark]

What does this PR do?

Remove the unused key-value store package from the codebase. This PR deletes the entire kv package and its MySQL implementation, which was designed for key-value storage with TTL support and workspace isolation.

Fixes # (issue)

Type of change

• Chore (refactoring code, technical debt, workflow improvements)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this be tested?

• Verify that no other parts of the codebase depend on the removed kv package
• Ensure the application builds and runs correctly without the removed code
• Check that any functionality previously using this package has been migrated to alternative solutions

Checklist

Required

• Filled out the "How to test" section in this PR
• Read Contributing Guide
• Self-reviewed my own code
• Commented on my code in hard-to-understand areas
• Ran pnpm build
• Ran pnpm fmt
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues

[changeset-bot]

⚠️ No Changeset found

Latest commit: 197ecd4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
dashboard	Ready	Preview	Comment	Oct 3, 2025 4:29pm
engineering	Ready	Preview	Comment	Oct 3, 2025 4:29pm

[chronark]

• chore: remove dead code (hydra) #4062
• chore: deleting dead code (kv package) #4061 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request removes the entire kv package and its MySQL-backed implementation, including public interfaces/types, sqlc configuration, generated code, SQL queries, schema, and package documentation. No replacement code is added.

Changes

Cohort / File(s)	Summary
KV public API removal go/pkg/kv/store.go, go/pkg/kv/doc.go	Deleted Store interface, KvEntry struct, and package docs.
MySQL store implementation removal go/pkg/kv/stores/mysql/store.go	Deleted MySQL-backed kv.Store implementation including constructors, methods, and connection management.
sqlc-generated code removal go/pkg/kv/stores/mysql/db.go, go/pkg/kv/stores/mysql/models.go, go/pkg/kv/stores/mysql/delete.sql.go, go/pkg/kv/stores/mysql/delete_expired.sql.go, go/pkg/kv/stores/mysql/get.sql.go, go/pkg/kv/stores/mysql/list_by_workspace.sql.go, go/pkg/kv/stores/mysql/set.sql.go	Removed generated DB interfaces, models, and CRUD methods for MySQL store.
SQL queries, schema, and config removal go/pkg/kv/stores/mysql/queries/*, go/pkg/kv/stores/mysql/schema.sql, go/pkg/kv/stores/mysql/sqlc.json	Deleted SQL query files (get, set, delete, list_by_workspace, delete_expired), table schema, and sqlc configuration.
Documentation removal go/pkg/kv/stores/mysql/doc.go	Deleted MySQL store package documentation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

• Delete entire kv package #3875 — Removes the entire go/pkg/kv package and MySQL implementation as requested.

Suggested reviewers

• imeyer
• perkinsjr
• Flo4604

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly indicates the removal of dead code in the kv package, succinctly capturing the primary change without extraneous details or ambiguity.
Description Check	✅ Passed	The description follows the repository template with a clear summary, type of change markings, detailed testing steps, and a complete checklist, though the placeholder “Fixes # (issue)” should be replaced with an actual issue number or removed if no issue exists.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 10-03-chore_deleting_dead_code_kv_package_

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 16d14f6 and 197ecd4.

📒 Files selected for processing (18)

• go/pkg/kv/doc.go (0 hunks)
• go/pkg/kv/store.go (0 hunks)
• go/pkg/kv/stores/mysql/db.go (0 hunks)
• go/pkg/kv/stores/mysql/delete.sql.go (0 hunks)
• go/pkg/kv/stores/mysql/delete_expired.sql.go (0 hunks)
• go/pkg/kv/stores/mysql/doc.go (0 hunks)
• go/pkg/kv/stores/mysql/get.sql.go (0 hunks)
• go/pkg/kv/stores/mysql/list_by_workspace.sql.go (0 hunks)
• go/pkg/kv/stores/mysql/models.go (0 hunks)
• go/pkg/kv/stores/mysql/queries/delete.sql (0 hunks)
• go/pkg/kv/stores/mysql/queries/delete_expired.sql (0 hunks)
• go/pkg/kv/stores/mysql/queries/get.sql (0 hunks)
• go/pkg/kv/stores/mysql/queries/list_by_workspace.sql (0 hunks)
• go/pkg/kv/stores/mysql/queries/set.sql (0 hunks)
• go/pkg/kv/stores/mysql/schema.sql (0 hunks)
• go/pkg/kv/stores/mysql/set.sql.go (0 hunks)
• go/pkg/kv/stores/mysql/sqlc.json (0 hunks)
• go/pkg/kv/stores/mysql/store.go (0 hunks)

💤 Files with no reviewable changes (18)

• go/pkg/kv/stores/mysql/queries/list_by_workspace.sql
• go/pkg/kv/stores/mysql/doc.go
• go/pkg/kv/stores/mysql/set.sql.go
• go/pkg/kv/store.go
• go/pkg/kv/stores/mysql/queries/get.sql
• go/pkg/kv/stores/mysql/get.sql.go
• go/pkg/kv/stores/mysql/queries/set.sql
• go/pkg/kv/doc.go
• go/pkg/kv/stores/mysql/models.go
• go/pkg/kv/stores/mysql/store.go
• go/pkg/kv/stores/mysql/schema.sql
• go/pkg/kv/stores/mysql/sqlc.json
• go/pkg/kv/stores/mysql/list_by_workspace.sql.go
• go/pkg/kv/stores/mysql/queries/delete.sql
• go/pkg/kv/stores/mysql/delete.sql.go
• go/pkg/kv/stores/mysql/delete_expired.sql.go
• go/pkg/kv/stores/mysql/db.go
• go/pkg/kv/stores/mysql/queries/delete_expired.sql

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Test Go API Local / Test
• GitHub Check: Test API / API Test Local
• GitHub Check: Build / Build

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[imeyer]

LGTM

[graphite-app]

[graphite-app]

Graphite Automations

"Post a GIF when PR approved" took an action on this PR • (10/03/25)

1 gif was posted to this PR based on Andreas Thomas's automation.