Skip to content

chore: remove apps/chproxy#4040

Merged
imeyer merged 1 commit intomainfrom
push-vqskuksowlwr
Sep 30, 2025
Merged

chore: remove apps/chproxy#4040
imeyer merged 1 commit intomainfrom
push-vqskuksowlwr

Conversation

@imeyer
Copy link
Contributor

@imeyer imeyer commented Sep 30, 2025

@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2025

⚠️ No Changeset found

Latest commit: abca2bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
dashboard Ready Ready Preview Comment Sep 30, 2025 1:04pm
engineering Ready Ready Preview Comment Sep 30, 2025 1:04pm

@vercel vercel bot temporarily deployed to Preview – engineering September 30, 2025 13:04 Inactive
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 30, 2025

📝 Walkthrough

Walkthrough

Removes the entire apps/chproxy application and related assets from the repository, including source code, tests, module files, Dockerfile, README, and .gitignore entries that previously ignored build artifacts.

Changes

Cohort / File(s) Summary of Changes
Remove chproxy source
apps/chproxy/batch.go, apps/chproxy/buffer.go, apps/chproxy/config.go, apps/chproxy/main.go, apps/chproxy/otel.go
Deleted all application source files, removing batching, buffering, config loading, server and handlers, and OTEL telemetry setup.
Remove chproxy tests
apps/chproxy/config_test.go
Deleted all tests for chproxy configuration.
Remove module metadata
apps/chproxy/go.mod
Deleted Go module declaration and dependencies for chproxy.
Remove container/build assets
apps/chproxy/Dockerfile, apps/chproxy/README.md
Deleted Dockerfile and README for chproxy.
Adjust ignore rules
apps/chproxy/.gitignore
Removed ignores for chproxy and coverage.out, changing Git tracking behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • perkinsjr
  • mcstepp
  • MichaelUnkey
  • ogzhanolguncu
  • chronark
  • Flo4604

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description only includes a reference to fixing issue #4039 and lacks the required sections from the repository template such as a summary of changes, type of change, testing instructions, and checklist, making it incomplete for reviewers. Please populate the pull request with the full description template by adding sections for what the PR does, the type of change, instructions on how to test, and the completed checklist to ensure clarity and traceability.
✅ Passed checks (4 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title clearly and concisely describes the primary change of removing the apps/chproxy component, aligning directly with the main modifications in the diff and using a standard conventional commit prefix.
Linked Issues Check ✅ Passed The changes thoroughly remove all files, configuration, and tests under apps/chproxy, fully satisfying the objective of linked issue #4039 to remove the chproxy component from the repository.
Out of Scope Changes Check ✅ Passed All modifications are confined to the apps/chproxy directory and its .gitignore, with no alterations outside the scope of removing the chproxy component, so there are no unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch push-vqskuksowlwr

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4cc548 and abca2bb.

⛔ Files ignored due to path filters (1)
  • apps/chproxy/go.sum is excluded by !**/*.sum
📒 Files selected for processing (10)
  • apps/chproxy/.gitignore (0 hunks)
  • apps/chproxy/Dockerfile (0 hunks)
  • apps/chproxy/README.md (0 hunks)
  • apps/chproxy/batch.go (0 hunks)
  • apps/chproxy/buffer.go (0 hunks)
  • apps/chproxy/config.go (0 hunks)
  • apps/chproxy/config_test.go (0 hunks)
  • apps/chproxy/go.mod (0 hunks)
  • apps/chproxy/main.go (0 hunks)
  • apps/chproxy/otel.go (0 hunks)
💤 Files with no reviewable changes (10)
  • apps/chproxy/Dockerfile
  • apps/chproxy/config_test.go
  • apps/chproxy/.gitignore
  • apps/chproxy/README.md
  • apps/chproxy/buffer.go
  • apps/chproxy/config.go
  • apps/chproxy/go.mod
  • apps/chproxy/batch.go
  • apps/chproxy/main.go
  • apps/chproxy/otel.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Build / Build
  • GitHub Check: Test API / API Test Local
  • GitHub Check: Test Go API Local / Test
  • GitHub Check: Test Packages / Test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

Thank you for following the naming conventions for pull request titles! 🙏

@vercel vercel bot temporarily deployed to Preview – dashboard September 30, 2025 13:04 Inactive
@imeyer imeyer enabled auto-merge September 30, 2025 13:04
@graphite-app
Copy link

graphite-app bot commented Sep 30, 2025

Photo gif. A hand giving a thumbs-up appears in front of a photo of Harrison Ford. (Added via Giphy)

@imeyer imeyer added the No Rabbit Disables CodeRabbit auto reviews label Sep 30, 2025
@coderabbitai coderabbitai bot requested review from Flo4604 and chronark September 30, 2025 13:05
@graphite-app
Copy link

graphite-app bot commented Sep 30, 2025

Graphite Automations

"Post a GIF when PR approved" took an action on this PR • (09/30/25)

1 gif was posted to this PR based on Andreas Thomas's automation.

@imeyer
Copy link
Contributor Author

imeyer commented Sep 30, 2025

wow @chronark @Flo4604 that was fast

Copy link
Member

Flo4604 commented Sep 30, 2025

I see remove code I press approve

Copy link
Member

Flo4604 commented Sep 30, 2025

and thanks rabbit for requesting us again after approving!

@imeyer imeyer added this pull request to the merge queue Sep 30, 2025
Merged via the queue into main with commit 16ab7bc Sep 30, 2025
18 checks passed
@imeyer imeyer deleted the push-vqskuksowlwr branch September 30, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Rabbit Disables CodeRabbit auto reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove chproxy from repo

3 participants