Closed
Conversation
…yed/unkey into 09-18-feat_sticky_rollbacks
chronark
requested review from
Flo4604,
MichaelUnkey,
imeyer,
mcstepp,
ogzhanolguncu and
perkinsjr
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughRefactors “active” to “live” across dashboard, hooks, and actions; updates rollback UI and mutation to target/live semantics; adds domain awareness. Backend replaces RoutingService with DeploymentService.Rollback, adds sticky domain semantics, gateway deployment_id, and DB schema/queries for rollback. Protos/codegen updated; polling added; minor infra/image and logging tweaks. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant UI as Dashboard UI
participant TRPC as TRPC Router (dashboard)
participant CTRL as Ctrl DeploymentService
participant DB as Core DB
participant PDB as Partition DB (gateways)
U->>UI: Open RollbackDialog (live & target deployments)
UI->>TRPC: mutation.deploy.rollback({ targetDeploymentId })
TRPC->>CTRL: Rollback(project_id, target_deployment_id)
CTRL->>DB: Validate project, live & target deployments
CTRL->>DB: Fetch sticky domains on live
CTRL->>PDB: Find gateway config by target deployment
alt Eligible sticky domains
CTRL->>PDB: Bulk upsert gateways (deployment_id, hostname, config)
loop For each domain
CTRL->>DB: RollBackDomain(id, target_deployment_id, is_rolled_back=true)
end
CTRL->>DB: Update project.live_deployment_id
CTRL-->>TRPC: { domains }
TRPC-->>UI: success
UI-->>U: Show success and refetch lists
else None eligible
CTRL-->>TRPC: InvalidArgument error
TRPC-->>UI: error
UI-->>U: Show error
end
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Suggested labels
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (46)
📒 Files selected for processing (47)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
UI/UX
Performance/Reliability