fix(dashboard): use env_file to read dashboard env first#3790
Conversation
mcstepp
requested review from
Flo4604,
MichaelUnkey,
chronark,
ogzhanolguncu and
perkinsjr
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
📝 WalkthroughWalkthroughUpdated Changes
Sequence Diagram(s)sequenceDiagram
participant CI as GitHub Actions
participant FS as Repo filesystem
participant DC as Docker Compose
CI->>FS: mkdir -p ./apps/dashboard && touch ./apps/dashboard/.env
CI->>DC: docker compose up
DC->>FS: read ../apps/dashboard/.env for dashboard service env
DC->>DashboardContainer: start with env from file + remaining inline env
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these settings in your CodeRabbit configuration.
📒 Files selected for processing (1)
deployment/docker-compose.yaml(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: chronark
PR: unkeyed/unkey#3638
File: deployment/docker-compose.yaml:81-94
Timestamp: 2025-07-22T09:02:12.495Z
Learning: The docker-compose.yaml file in deployment/ is specifically for development environments, not production. Kafka and other service configurations in this file should be optimized for development convenience rather than production security/hardening.
🪛 YAMLlint (1.37.1)
deployment/docker-compose.yaml
[error] 209-209: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build / Build
- GitHub Check: Analyze (javascript-typescript)
…de with specific docker variables
mcstepp
force-pushed
the
improve-deploy-docker
branch
from
718360c to
9504f46
Compare
|
FYI fixing it. CI/CD is yelling about no .env file |
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these settings in your CodeRabbit configuration.
📒 Files selected for processing (2)
.github/workflows/job_test_api_local.yaml(1 hunks).github/workflows/job_test_go_api_local.yaml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: chronark
PR: unkeyed/unkey#3638
File: deployment/docker-compose.yaml:81-94
Timestamp: 2025-07-22T09:02:12.495Z
Learning: The docker-compose.yaml file in deployment/ is specifically for development environments, not production. Kafka and other service configurations in this file should be optimized for development convenience rather than production security/hardening.
🔇 Additional comments (2)
.github/workflows/job_test_go_api_local.yaml (1)
12-15: Solid fix to unblock Compose parse by ensuring the dashboard .env exists.This guards against docker compose failing early due to the new env_file requirement. Placement right after checkout is fine and idempotent.
.github/workflows/job_test_api_local.yaml (1)
15-18: Good placement before docker compose up; prevents early failure.Creating ./apps/dashboard/.env before “Run containers” aligns with the env_file change and keeps this job green without altering runtime behavior.
|
hi frens :sob-cat: |
|
|
Graphite Automations"Post a GIF when PR approved" took an action on this PR • (08/15/25)1 gif was posted to this PR based on Andreas Thomas's automation. |
2 participants
What does this PR do?
./apps/dashboard/.envThis follows Docker Compose best practices for configuration management and makes the setup more maintainable for local development.
Updates to Github Flows
Docker Compose parses and validates the entire compose file before starting any services, even if you're only running specific ones; the two workflows in question are not starting the dashboard service.
When it encounters the env_file directive, it immediately tries to verify that the file exists, regardless of whether that service will actually be started.
Type of change
How should this be tested?
One way to test would be to verify your env file is loaded:
Checklist
Required
pnpm buildpnpm fmtconsole.logsgit pull origin mainAppreciated
Summary by CodeRabbit
Security
Chores