chore: add more metrics for batching etc by chronark · Pull Request #3651 · unkeyed/unkey

chronark · 2025-07-23T11:10:32Z

What does this PR do?

This PR adds comprehensive batch processing metrics and improves the batch processing implementation. It:

Adds new Prometheus metrics for batch operations:
- BatchSizeDistribution to track batch sizes when flushed
- BatchOperationsTotal to count batch flush operations
- BatchItemsProcessedTotal to measure throughput
Enhances the batch processor to track the trigger reason for flushes (size limit, time interval, or close)
Increases batch sizes in Clickhouse client from 1000 to 10000 for API requests, key verifications, and rate limits
Adds HTTP request body size metrics to monitor payload sizes
Removes the deprecated batch.consume.go file in favor of the more configurable implementation in batch.process.go
Fixes metric naming in buffer metrics by moving them from unkey_api_buffer_* to unkey_buffer_*

Fixes # (issue)

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
Enhancement (small improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How should this be tested?

Verify that the new Prometheus metrics are being collected correctly by checking the metrics endpoint
Test batch processing with different batch sizes to ensure metrics are recorded properly
Verify that increasing the batch sizes for Clickhouse operations doesn't cause any performance issues

Checklist

Required

changeset-bot · 2025-07-23T11:10:36Z

⚠️ No Changeset found

Latest commit: 3bdf6a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-07-23T11:10:38Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vercel · 2025-07-23T11:10:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 23, 2025 11:11am
engineering	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 23, 2025 11:11am

chronark · 2025-07-23T11:10:50Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

chore: add more metrics for batching etc #3651 👈 (View in Graphite)
feat: use the new api based chproxy #3648
chore: replace chproxy with our own api #3647
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

graphite-app · 2025-07-23T11:20:55Z

Flo4604 · 2025-07-23T11:21:19Z

Shouldnt go this into main or is the current merge location correct

chronark · 2025-07-23T11:22:47Z

nah I fucked up graphite

chronark · 2025-07-23T11:23:47Z

might as well merge this one now 😄
I tried to make it cleaner but guess I failed

graphite-app · 2025-07-23T11:25:11Z

Graphite Automations

"Post a GIF when PR approved" took an action on this PR • (07/23/25)

1 gif was posted to this PR based on Andreas Thomas's automation.

* chore: log params * fix: parallelize flushing * chore: replace chproxy with our own api * revert: api v1 changes * feat: use the new api based chproxy * fix: uncomment the container as we still need it * fix: add json tags to bind properly * fix: error handling * chore: add more metrics for batching etc (#3651) * fix: laod env correctly * ci: run apiv2 instead of chproxy * Update apps/api/src/pkg/analytics.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * style: fmt --------- Co-authored-by: Flo <53355483+Flo4604@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

chore: add more metrics for batching etc

3bdf6a9

chronark mentioned this pull request Jul 23, 2025

chore: replace chproxy with our own api #3647

Merged

16 tasks

chronark mentioned this pull request Jul 23, 2025

feat: use the new api based chproxy #3648

Merged

18 tasks

chronark marked this pull request as ready for review July 23, 2025 11:11

chronark requested review from Flo4604, imeyer and perkinsjr as code owners July 23, 2025 11:11

vercel bot temporarily deployed to Preview – engineering July 23, 2025 11:11 Inactive

vercel bot temporarily deployed to Preview – dashboard July 23, 2025 11:11 Inactive

Flo4604 approved these changes Jul 23, 2025

View reviewed changes

chronark merged commit 799f069 into 07-22-feat_use_the_new_api_based_chproxy Jul 23, 2025
11 checks passed

chronark deleted the 07-23-chore_add_more_metrics_for_batching_etc branch July 23, 2025 11:23

Conversation

chronark commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

How should this be tested?

Checklist

Required

Uh oh!

changeset-bot bot commented Jul 23, 2025

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

vercel bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chronark commented Jul 23, 2025

Uh oh!

graphite-app bot commented Jul 23, 2025

Uh oh!

Flo4604 commented Jul 23, 2025

Uh oh!

chronark commented Jul 23, 2025

Uh oh!

chronark commented Jul 23, 2025

Uh oh!

Uh oh!

graphite-app bot commented Jul 23, 2025

Graphite Automations

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chronark commented Jul 23, 2025 •

edited

Loading

coderabbitai bot commented Jul 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

vercel bot commented Jul 23, 2025 •

edited

Loading