test: merge integration tests in single package#3629
Closed
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Contributor
📝 WalkthroughWalkthroughThe code was refactored to remove per-test-case package generation for test files. All generated test files are now placed in a single Changes
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (54)
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
🔇 Additional comments (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
18 tasks
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
we now try to listen on a random port assigned by the OS and never stop listening until the tests are done. This prevents the race conditions between assigning a port and using it
Go test would build each package before discovering that it should be skipped. Now it just needs to build one package. We're not sharding tests in CI anymore, so this is fine.
chronark
force-pushed
the
07-17-test_merge_integration_tests_in_single_package
branch
from
43cdf11 to
46ba360
Compare
chronark
force-pushed
the
07-17-fix_port_allocation_in_tests
branch
from
96638e7 to
c3fa9b5
Compare
Contributor
|
Thank you for following the naming conventions for pull request titles! 🙏 |
perkinsjr
approved these changes
Jul 17, 2025
|
|
Graphite Automations"Post a GIF when PR approved" took an action on this PR • (07/17/25)1 gif was posted to this PR based on Andreas Thomas's automation. "Notify author when CI fails" took an action on this PR • (07/17/25)1 teammate was notified to this PR based on Andreas Thomas's automation. |
Collaborator
Author
|
ooh sweet child, you’ll be so dissapointed when graphite invalidates this one |
Member
|
I used graphite to approve it. :pepehands: |
Collaborator
Author
|
again I don’t think that makes any difference 😄 but let’s see |
Collaborator
Author
|
I think this one is a lost cause, github now consistently kills the tests for consuming too much CPU 😄 |
Member
|
🙃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Consolidates rate limiting integration tests into a single package to improve test organization and execution. This change:
generatedpackage instead of creating separate packages for each test casePackageName()function which is no longer neededtmpltotestTmplfor clarityType of change
How should this be tested?
go generatein the multi_node_ratelimiting directory to verify tests are generated correctlygo test ./go/apps/api/integration/multi_node_ratelimiting/generated/...Checklist
Required
Summary by CodeRabbit