Conversation
chronark
requested review from
MichaelUnkey,
mcstepp,
ogzhanolguncu and
perkinsjr
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThe workflow configuration for container image retention was updated to retain the 10 most recent images and to enable dry-run mode, so deletions are simulated rather than executed. No changes were made to any exported or public code entities. Changes
Sequence Diagram(s)Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/ghcr_retention_policy.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Test Packages / Test ./apps/dashboard
- GitHub Check: Test Packages / Test ./internal/clickhouse
- GitHub Check: Test Packages / Test ./packages/cache
- GitHub Check: Test Packages / Test ./internal/encryption
- GitHub Check: Analyze (javascript-typescript)
| token: ${{ secrets.PAT }} | ||
| image-names: "unkey agent" | ||
| image-tags: "!latest" | ||
| keep-n-most-recent: 10 |
There was a problem hiding this comment.
Unknown input – action expects keep-n, not keep-n-most-recent.
snok/container-retention-policy@v3.0.0 defines an input named keep-n.
Using an undefined input silently does nothing, so no “keep last 10” safeguard will be applied.
- keep-n-most-recent: 10
+ keep-n: 10📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| keep-n-most-recent: 10 | |
| keep-n: 10 |
🤖 Prompt for AI Agents
In .github/workflows/ghcr_retention_policy.yaml at line 20, the input name used
is `keep-n-most-recent`, but the action `snok/container-retention-policy@v3.0.0`
expects the input to be named `keep-n`. Replace `keep-n-most-recent` with
`keep-n` to ensure the retention policy correctly keeps the last 10 items as
intended.
| keep-n-most-recent: 10 | ||
| cut-off: 4w | ||
| dry-run: false | ||
| dry-run: true |
There was a problem hiding this comment.
💡 Verification agent
❓ Verification inconclusive
dry-run: true means no images will actually be deleted.
Fine for validation, but remember to flip to false once you’re confident the policy is correct; otherwise the job becomes a no-op.
Action Required: Disable dry-run after validation
dry-run: true means the cleanup won’t actually delete any images—useful for testing, but it turns the job into a no-op. Once you’ve confirmed the retention policy behaves as expected, update this to false so images are truly pruned.
• File: .github/workflows/ghcr_retention_policy.yaml
• Line 22:
- dry-run: true
+ dry-run: false📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| dry-run: true | |
| dry-run: false |
🤖 Prompt for AI Agents
In .github/workflows/ghcr_retention_policy.yaml at line 22, the dry-run option
is set to true, which prevents actual deletion of images during cleanup. After
validating the retention policy, change the value of dry-run from true to false
to enable real pruning of images.
2 participants
What does this PR do?
Fixes # (issue)
If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists
Type of change
How should this be tested?
Checklist
Required
pnpm buildpnpm fmtconsole.logsgit pull origin mainAppreciated
Summary by CodeRabbit