test: fix dashboard tests by ogzhanolguncu · Pull Request #3391 · unkeyed/unkey

ogzhanolguncu · 2025-06-18T12:58:13Z

What does this PR do?

This PR removes redundant test and fixes other test related issues. Main reason for this PR is, we removed a filter called requestIds from filter.ts, but forgot to remove it from tests.

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
Enhancement (small improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How should this be tested?

Nothing to test.

Checklist

Required

Appreciated

If a UI change was made: Added a screen recording or screenshots to this PR
Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

Refactor
- Removed support for the requestIds filter from rate limit log filtering and related tests.
Tests
- Deleted tests for the log query hook.
- Updated filter hook tests to exclude requestIds scenarios.

…ix-dashboard-tests

changeset-bot · 2025-06-18T12:58:17Z

⚠️ No Changeset found

Latest commit: e5557d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-06-18T12:58:18Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 18, 2025 0:59am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
engineering	⬜️ Ignored (Inspect)			Jun 18, 2025 0:59am

coderabbitai · 2025-06-18T12:58:19Z

📝 Walkthrough

Walkthrough

The changes remove all support for the requestIds filter from the rate limit logs feature. This includes deleting the test file for the logs query hook, updating the filters hook and its tests to eliminate requestIds, and removing requestIds from the exported filter payload.

Changes

File(s)	Change Summary
.../logs/components/table/hooks/use-logs-query.test.tsx	Deleted the test file for the `useRatelimitLogsQuery` hook, removing all related test logic.
.../logs/hooks/use-filters.test.ts	Removed all references to `requestIds` in test mocks, assertions, and test cases.
.../logs/hooks/use-filters.ts	Removed the `requestIds` property from the exported `queryParamsPayload` constant.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant useFilters
    participant FilterPayload

    User->>useFilters: Set or update filters
    useFilters->>FilterPayload: Build payload (without requestIds)
    FilterPayload-->>useFilters: Return payload (identifiers, status, startTime, endTime, since)
    useFilters-->>User: Apply filters (requestIds not included)

Possibly related PRs

refactor: filter types for logs page #2878: Refactors filter types and schemas for the logs page, directly related to changes in filter type definitions and validation schemas.

Suggested reviewers

perkinsjr
mcstepp
chronark

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 79665cf and e5557d6.

📒 Files selected for processing (3)

apps/dashboard/app/(app)/ratelimits/[namespaceId]/logs/components/table/hooks/use-logs-query.test.tsx (0 hunks)
apps/dashboard/app/(app)/ratelimits/[namespaceId]/logs/hooks/use-filters.test.ts (0 hunks)
apps/dashboard/app/(app)/ratelimits/[namespaceId]/logs/hooks/use-filters.ts (0 hunks)

💤 Files with no reviewable changes (3)

apps/dashboard/app/(app)/ratelimits/[namespaceId]/logs/hooks/use-filters.ts
apps/dashboard/app/(app)/ratelimits/[namespaceId]/logs/hooks/use-filters.test.ts
apps/dashboard/app/(app)/ratelimits/[namespaceId]/logs/components/table/hooks/use-logs-query.test.tsx

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: Test Packages / Test ./packages/cache
GitHub Check: Test Packages / Test ./internal/clickhouse
GitHub Check: Test Packages / Test ./internal/encryption
GitHub Check: Test Packages / Test ./internal/hash
GitHub Check: autofix
GitHub Check: Analyze (javascript-typescript)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-06-18T12:58:22Z

Thank you for following the naming conventions for pull request titles! 🙏

ogzhanolguncu added 3 commits June 18, 2025 15:56

tests: fix tests and remove redudant test

035d9a8

test: fix tests and remove redudant test

7977fff

Merge branch 'fix-dashboard-tests' of github.com:unkeyed/unkey into f…

e5557d6

…ix-dashboard-tests

ogzhanolguncu marked this pull request as ready for review June 18, 2025 12:59

ogzhanolguncu requested review from chronark, mcstepp and perkinsjr as code owners June 18, 2025 12:59

vercel bot deployed to Preview – dashboard June 18, 2025 12:59 View deployment

chronark approved these changes Jun 19, 2025

View reviewed changes

chronark merged commit 0865de3 into main Jun 19, 2025
32 of 33 checks passed

chronark deleted the fix-dashboard-tests branch June 19, 2025 07:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: fix dashboard tests#3391

test: fix dashboard tests#3391
chronark merged 3 commits intomainfrom
fix-dashboard-tests

ogzhanolguncu commented Jun 18, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Jun 18, 2025

Uh oh!

vercel bot commented Jun 18, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 18, 2025 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jun 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ogzhanolguncu commented Jun 18, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

How should this be tested?

Checklist

Required

Appreciated

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Jun 18, 2025

⚠️ No Changeset found

Uh oh!

vercel bot commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ogzhanolguncu commented Jun 18, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Jun 18, 2025 •

edited

Loading

coderabbitai bot commented Jun 18, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Jun 18, 2025 •

edited

Loading