fix: align margin for info icon and description text by MichaelUnkey · Pull Request #3386 · unkeyed/unkey

MichaelUnkey · 2025-06-17T19:20:56Z

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
Enhancement (small improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How should this be tested?

Desired left side margin for info icon shows in Chrome and Safari
Info text should align with checkbox text

Checklist

Required

Appreciated

If a UI change was made: Added a screen recording or screenshots to this PR
Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

Style
- Improved spacing and alignment for icons and text in form descriptions and error messages.
- Reduced horizontal gap between checkboxes and their labels.
- Adjusted checkbox and icon sizes for a more compact appearance.
- Increased checkbox size in confirmation dialogs for deleting keys, permissions, and roles.
- Updated padding and spacing in rate limit setup and related form components for better visual consistency.
Refactor
- Standardized the display of form descriptions and errors by consolidating logic into a reusable component.

linear · 2025-06-17T19:21:00Z

ENG-1846 Fix size and issue of info icon in FormCheckbox

changeset-bot · 2025-06-17T19:21:01Z

⚠️ No Changeset found

Latest commit: a462657

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-06-17T19:21:01Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2025 11:22am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
engineering	⬜️ Ignored (Inspect)	Visit Preview		Jun 20, 2025 11:22am

coderabbitai · 2025-06-17T19:21:04Z

📝 Walkthrough

Walkthrough

This change standardizes and adjusts UI component spacing and sizing across several form-related components. It updates icon and text alignment in FormDescription, reduces checkbox and icon sizes, refines spacing between checkboxes and labels, and consolidates description/error rendering using the FormDescription component in various form elements. No logic or control flow is altered.

Changes

File(s)	Change Summary
internal/ui/src/components/form/form-helpers.tsx	Adjusted horizontal margins of the `TriangleWarning2` icon in `FormDescription`.
apps/dashboard/app/(app)/apis/[apiId]/_components/create-key/components/credits-setup.tsx	Replaced manual description and icon rendering with `FormDescription` component.
apps/dashboard/components/ui/form-combobox.tsx	Replaced inline error/description rendering with `FormDescription` component.
apps/dashboard/app/(app)/apis/[apiId]/_components/create-key/components/ratelimit-setup.tsx	Removed `px-1` padding class from ratelimit fields container.
internal/ui/src/components/checkbox.tsx	Reduced checkbox size variants and updated corresponding icon sizes.
internal/ui/src/components/form/form-checkbox.tsx	Reduced horizontal gap between checkbox and label from 3 to 2 units.
apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/_components/components/table/components/actions/...	Changed `FormCheckbox` size from "md" to "lg" for delete and disable key dialogs.
apps/dashboard/app/(app)/authorization/permissions/components/table/components/actions/components/delete...	Changed `FormCheckbox` size from "md" to "lg" for delete permission dialog.
apps/dashboard/app/(app)/authorization/roles/components/table/components/actions/components/delete-role.tsx	Changed `FormCheckbox` size from "md" to "lg" for delete role dialog.

Possibly related PRs

refactor: ui package style inconsistencies #3265: Introduces the FormDescription component and refactors form components to use it, directly related to this PR's further standardization and spacing adjustments.
fix: remove copy pasted description #2914: Modifies styling and usage of FormDescription component and icons, related to this PR's changes in form helper UI elements.

Suggested labels

Bug, 🕹️ oss.gg, :joystick: 150 points

Suggested reviewers

chronark
ogzhanolguncu

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-06-17T19:21:07Z

Thank you for following the naming conventions for pull request titles! 🙏

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 70a92a5 and d56ea14.

📒 Files selected for processing (2)

internal/ui/src/components/form/form-helpers.tsx (2 hunks)
packages/hono/package.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

GitHub Check: Test Go API Local / Test (Shard 3/8)
GitHub Check: Test Go API Local / Test (Shard 4/8)
GitHub Check: Test Go API Local / Test (Shard 5/8)
GitHub Check: Test Go API Local / Test (Shard 1/8)
GitHub Check: Test Go API Local / Test (Shard 2/8)
GitHub Check: Build / Build
GitHub Check: Test API / API Test Local

🔇 Additional comments (2)

packages/hono/package.json (1)

11-16: Formatting-only update looks good.

Converting the keywords and files arrays to single-line representations is purely stylistic and has no impact on functionality.
internal/ui/src/components/form/form-helpers.tsx (1)

53-59: I’ll inspect the surrounding context in form-helpers.tsx to verify if there’s a parent flex gap-2 and how margins are applied:
#!/bin/bash
# Locate the file and print its first 200 lines for context
file=$(fd form-helpers.tsx)
echo "Found file: $file"
sed -n '1,200p' "$file"

internal/ui/src/components/form/form-helpers.tsx

ogzhanolguncu · 2025-06-17T20:24:14Z

Spacing seems too much

This is prod

Btw, why are we doing that?

chronark · 2025-06-17T20:39:09Z

To align them with checkboxes, see https://linear.app/unkey/issue/ENG-1846/fix-size-and-issue-of-info-icon-in-formcheckbox

ogzhanolguncu · 2025-06-17T20:41:02Z

I’ll check tomorrow morning

ogzhanolguncu · 2025-06-18T09:19:09Z

@chronark I think i noticed that and fixed it in somewhere else lemme see the PRs

ogzhanolguncu · 2025-06-18T09:19:28Z

#3330

chronark · 2025-06-18T09:20:02Z

ah damn
well that goes to show once more that asking stuff in DMs is bad

ogzhanolguncu · 2025-06-18T09:20:36Z

Still not exactly 100% aligned, but if we make the checkboxer closer to label it will cramp things up or if we make info and text further apart it will look weird

chronark · 2025-06-18T09:21:12Z

wait this is not fixed though
CleanShot 2025-06-18 at 11.20.39@2x.png

ogzhanolguncu · 2025-06-18T09:21:20Z

see my text above

chronark · 2025-06-18T09:21:34Z

what’s wrong with mike’s solution?

ogzhanolguncu · 2025-06-18T09:21:41Z

if we can make the checkbox smaller then we can align it perfectly

ogzhanolguncu · 2025-06-18T09:22:04Z

image.png

chronark · 2025-06-18T09:22:07Z

just add a div around the icon with the same size of the checkbox and center the icon inside

ogzhanolguncu · 2025-06-18T09:22:16Z

this SS is from preview branch. info and text looks too separated

chronark · 2025-06-18T09:23:09Z

the middle one looks fine
CleanShot 2025-06-18 at 11.22.25@2x.png

ogzhanolguncu · 2025-06-18T09:23:36Z

yeah probably mike forgot to change selects spacing 😄

chronark · 2025-06-18T09:23:51Z

either way, what are we going to do here?

make it look the same everywhere
accept that it looks like a 3 year old built this with different spacings everywhere? ,😄

ogzhanolguncu · 2025-06-18T09:24:02Z

okay i'll let mike work on this and we'll be in touch

chronark · 2025-06-18T09:24:09Z

:ty:

ogzhanolguncu · 2025-06-18T09:24:15Z

im closing my pr

ogzhanolguncu · 2025-06-18T09:25:09Z

@MichaelUnkey let's sync for this

…-fix-size-and-issue-of-info-icon-in-formcheckbox

…x' of https://github.com/unkeyed/unkey into eng-1846-fix-size-and-issue-of-info-icon-in-formcheckbox

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd6d3e9 and a462657.

📒 Files selected for processing (1)

internal/ui/src/components/form/form-helpers.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (12)

GitHub Check: Test Go API Local / Test (Shard 7/8)
GitHub Check: Test Go API Local / Test (Shard 2/8)
GitHub Check: Test Go API Local / Test (Shard 3/8)
GitHub Check: Build / Build
GitHub Check: Test API / API Test Local
GitHub Check: Test Packages / Test ./packages/cache
GitHub Check: Test Packages / Test ./packages/nextjs
GitHub Check: Test Packages / Test ./internal/resend
GitHub Check: Test Packages / Test ./packages/api
GitHub Check: Test Packages / Test ./internal/clickhouse
GitHub Check: autofix
GitHub Check: Analyze (javascript-typescript)

internal/ui/src/components/form/form-helpers.tsx

…-fix-size-and-issue-of-info-icon-in-formcheckbox

MichaelUnkey added 2 commits June 17, 2025 14:48

extra margin center icon

00a14d9

reverted variants for eng back and small change to helpers

d56ea14

vercel bot deployed to Preview – engineering June 17, 2025 19:22 View deployment

vercel bot deployed to Preview – dashboard June 17, 2025 19:22 View deployment

MichaelUnkey marked this pull request as ready for review June 17, 2025 19:24

MichaelUnkey requested review from chronark, mcstepp, ogzhanolguncu and perkinsjr as code owners June 17, 2025 19:24

MichaelUnkey enabled auto-merge June 17, 2025 19:24

coderabbitai bot reviewed Jun 17, 2025

View reviewed changes

internal/ui/src/components/form/form-helpers.tsx Show resolved Hide resolved

ogzhanolguncu self-assigned this Jun 17, 2025

MichaelUnkey added 5 commits June 18, 2025 13:34

revert

73a171c

opps

b5bdab8

Merge branch 'main' of https://github.com/unkeyed/unkey into eng-1846…

4178038

…-fix-size-and-issue-of-info-icon-in-formcheckbox

suggested changes

8b696a9

Merge branch 'eng-1846-fix-size-and-issue-of-info-icon-in-formcheckbo…

cd6d3e9

…x' of https://github.com/unkeyed/unkey into eng-1846-fix-size-and-issue-of-info-icon-in-formcheckbox

vercel bot deployed to Preview – engineering June 18, 2025 20:10 View deployment

vercel bot deployed to Preview – dashboard June 18, 2025 20:10 View deployment

fix merge issue

a462657

vercel bot deployed to Preview – engineering June 18, 2025 20:28 View deployment

coderabbitai bot reviewed Jun 18, 2025

View reviewed changes

internal/ui/src/components/form/form-helpers.tsx Show resolved Hide resolved

vercel bot deployed to Preview – dashboard June 18, 2025 20:29 View deployment

Merge branch 'main' of https://github.com/unkeyed/unkey into eng-1846…

0876a45

…-fix-size-and-issue-of-info-icon-in-formcheckbox

vercel bot deployed to Preview – dashboard June 20, 2025 11:22 View deployment

ogzhanolguncu approved these changes Jun 20, 2025

View reviewed changes

MichaelUnkey added this pull request to the merge queue Jun 20, 2025

Merged via the queue into main with commit 3a5a947 Jun 20, 2025
33 of 37 checks passed

MichaelUnkey deleted the eng-1846-fix-size-and-issue-of-info-icon-in-formcheckbox branch June 20, 2025 13:17

coderabbitai bot mentioned this pull request Aug 15, 2025

feat: Root key creation redesign. #3779

Merged

18 tasks

Conversation

MichaelUnkey commented Jun 17, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

How should this be tested?

Checklist

Required

Appreciated

Summary by CodeRabbit

Uh oh!

linear bot commented Jun 17, 2025

Uh oh!

changeset-bot bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ogzhanolguncu commented Jun 17, 2025

Uh oh!

chronark commented Jun 17, 2025

Uh oh!

ogzhanolguncu commented Jun 17, 2025

Uh oh!

ogzhanolguncu commented Jun 18, 2025

Uh oh!

ogzhanolguncu commented Jun 18, 2025

Uh oh!

chronark commented Jun 18, 2025

Uh oh!

ogzhanolguncu commented Jun 18, 2025

Uh oh!

chronark commented Jun 18, 2025

Uh oh!

ogzhanolguncu commented Jun 18, 2025

Uh oh!

chronark commented Jun 18, 2025

Uh oh!

ogzhanolguncu commented Jun 18, 2025

Uh oh!

ogzhanolguncu commented Jun 18, 2025

Uh oh!

chronark commented Jun 18, 2025

Uh oh!

ogzhanolguncu commented Jun 18, 2025

Uh oh!

chronark commented Jun 18, 2025

Uh oh!

ogzhanolguncu commented Jun 18, 2025

Uh oh!

chronark commented Jun 18, 2025

Uh oh!

ogzhanolguncu commented Jun 18, 2025

Uh oh!

chronark commented Jun 18, 2025

Uh oh!

ogzhanolguncu commented Jun 18, 2025

MichaelUnkey commented Jun 17, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Jun 17, 2025 •

edited

Loading

vercel bot commented Jun 17, 2025 •

edited

Loading

coderabbitai bot commented Jun 17, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Jun 17, 2025 •

edited

Loading