fix: added scroll y to default content area in dialogs

[MichaelUnkey]

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Chore (refactoring code, technical debt, workflow improvements)
• Enhancement (small improvements)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How should this be tested?

1. Shows the same as production before changes.
2. Id Dialog has to many items only the content will be scrollable

Checklist

Required

• Filled out the "How to test" section in this PR
• Read Contributing Guide
• Self-reviewed my own code
• Commented on my code in hard-to-understand areas
• Ran pnpm build
• Ran pnpm fmt
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

• Style
  • Improved layout and scrolling behavior for permission and dialog components, including enhanced flexbox layouts and updated overflow handling for smoother user experience.

[changeset-bot]

⚠️ No Changeset found

Latest commit: c6ad698

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 9, 2025 2:08pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
engineering	⬜️ Ignored (Inspect)	Visit Preview		Jun 9, 2025 2:08pm

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update CSS utility classes on several UI components to adjust their flexbox layout, overflow behavior, and scrolling. These modifications affect card and dialog containers, making them more flexible and responsive by leveraging flexbox and controlling overflow and scroll visibility.

Changes

File(s)	Change Summary
apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/[keyId]/components/rbac/permissions.tsx	Updated Card component classes to use flex column layout, flex-grow, and a minimum height constraint.
internal/ui/src/components/dialog/dialog-container.tsx	Changed DialogContent classes from vertical scroll to hidden overflow and added flex column layout.
internal/ui/src/components/dialog/parts/dialog-parts.tsx	Enhanced DefaultDialogContentArea with vertical scrolling, hidden scrollbar, and flex-grow.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI_Component
    participant Dialog/Card

    User->>UI_Component: Interacts with dialog/card
    UI_Component->>Dialog/Card: Renders with updated flex and overflow classes
    Dialog/Card-->>UI_Component: Displays with new layout and scrolling behavior
    UI_Component-->>User: Shows updated UI

Loading

Possibly related PRs

• chore: update default width of dialog #3283: Both PRs modify CSS classes for flexbox layout and scrolling in dialog or card components to improve flexible layout and scroll handling.

Suggested labels

Bug, 🕹️ oss.gg, :joystick: 150 points

Suggested reviewers

• mcstepp
• chronark
• perkinsjr

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4ff69b7 and 3e96eb9.

📒 Files selected for processing (3)

• apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/[keyId]/components/rbac/permissions.tsx (1 hunks)
• internal/ui/src/components/dialog/dialog-container.tsx (1 hunks)
• internal/ui/src/components/dialog/parts/dialog-parts.tsx (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

internal/ui/src/components/dialog/parts/dialog-parts.tsx (1)

apps/dashboard/lib/utils.ts (1)

• cn (5-7)

⏰ Context from checks skipped due to timeout of 90000ms (15)

• GitHub Check: Test Go API Local / Test (Shard 5/8)
• GitHub Check: Test Go API Local / Test (Shard 7/8)
• GitHub Check: Test Go API Local / Test (Shard 6/8)
• GitHub Check: Test Go API Local / Test (Shard 8/8)
• GitHub Check: Test Go API Local / Test (Shard 2/8)
• GitHub Check: Test Go API Local / Test (Shard 4/8)
• GitHub Check: Test Go API Local / Test (Shard 1/8)
• GitHub Check: Test Go API Local / Test (Shard 3/8)
• GitHub Check: Test API / API Test Local
• GitHub Check: Build / Build
• GitHub Check: Test Packages / Test ./packages/nextjs
• GitHub Check: Test Packages / Test ./internal/clickhouse
• GitHub Check: Test Packages / Test ./packages/api
• GitHub Check: Test Packages / Test ./internal/keys
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (3)

internal/ui/src/components/dialog/parts/dialog-parts.tsx (1)

40-45:

Details

✅ Verification successful

LGTM! Core scrolling functionality properly implemented.

The addition of overflow-y-auto, scrollbar-hide, and flex-grow correctly implements the content-area-only scrolling as described in the PR objectives. This ensures only the dialog content scrolls, not the entire dialog.

Verify that the scrollbar-hide utility class is defined in your Tailwind CSS configuration:

---

🏁 Script executed:

#!/bin/bash
# Description: Check if scrollbar-hide utility is defined in Tailwind config
# Expected: Find utility definition or usage in CSS files

rg -A 3 "scrollbar-hide" --type css
fd "tailwind" --exec cat {} \; | rg -A 5 "scrollbar"

Length of output: 903

---

Verified scrollbar-hide Utility Exists

I’ve confirmed that the scrollbar-hide class is defined in your Tailwind CSS setup:

• apps/dashboard/styles/tailwind/tailwind.css
• .scrollbar-hide::-webkit-scrollbar { display: none; }
• .scrollbar-hide { -ms-overflow-style: none; scrollbar-width: none; }

No further action is needed—your overflow-y-auto, scrollbar-hide, and flex-grow changes are good to merge.

internal/ui/src/components/dialog/dialog-container.tsx (1)

39-39: Critical change properly implements container-level scroll control.

The transition from overflow-y-auto to overflow-hidden combined with flex flex-col flex-grow is essential for the scrolling fix. This ensures the dialog container doesn't scroll while providing proper flex layout for the content area to handle scrolling internally.

apps/dashboard/app/(app)/apis/[apiId]/keys/[keyAuthId]/[keyId]/components/rbac/permissions.tsx (1)

58-58: Flex layout addition supports the overall scrolling improvements.

The addition of flex flex-col flex-grow aligns with the dialog scrolling fixes and ensures proper layout behavior when this component is used within flex containers.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏