fix: only allow access membership list fetching to current org context

[mcstepp]

What does this PR do?

Fixes ENG-1716

• correctly applied middleware to require org access to a membership list route for query.
• Updated definition of middleware to require org access to ensure that requested org id matched the user's authenticated context

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Chore (refactoring code, technical debt, workflow improvements)
• Enhancement (small improvements)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How should this be tested?

• Login as user with at least two organizations/workspaces (A and B), authenticate into org A
• Request getMembershipList(orgID) where orgId is org B
• Expect error

Checklist

Required

• Filled out the "How to test" section in this PR
• Read Contributing Guide
• Self-reviewed my own code
• Commented on my code in hard-to-understand areas
• Ran pnpm build
• Ran pnpm fmt
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

• New Features

  • Improved organization member listing process with context-based retrieval of organization ID.

• Bug Fixes

  • Removed outdated organization access verification middleware, simplifying access control management.

• Documentation

  • Reformatted documentation for improved readability without altering content or structure.

[linear]

ENG-1716 A user should only be able to get the membership list of the org they are currently authenticated in

[changeset-bot]

⚠️ No Changeset found

Latest commit: 15bc099

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 14, 2025 3:59pm
engineering	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 14, 2025 3:59pm
play	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 14, 2025 3:59pm
www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 14, 2025 3:59pm

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes modify the organization access control in the dashboard API. The getOrganizationMemberList procedure now retrieves the organization ID from the context instead of accepting it as an input parameter. Additionally, the requireOrgAccess middleware has been removed, eliminating the access verification based on organization membership. The error handling and logging mechanisms in the getOrganizationMemberList procedure remain unchanged.

Changes

File(s)	Change Summary
apps/dashboard/lib/trpc/routers/org/getOrganizationMemberList.ts	Modified the getOrganizationMemberList procedure to retrieve the organization ID from ctx.tenant.id instead of input.
apps/dashboard/lib/trpc/trpc.ts	Removed the requireOrgAccess middleware, which previously handled organization access verification.
apps/docs/docs.json	Reformatted "pages" arrays in several groups to improve readability by consolidating entries into single-line formats without altering content or structure.

Possibly related PRs

• fix: prevent cancellations if the org has multiple members #3099: The changes in the main PR modify the getOrganizationMemberList procedure, while the retrieved PR introduces a new functionality in the cancelSubscription procedure that utilizes the getOrganizationMemberList method, indicating a direct relationship between the two.

Suggested labels

Bug

Suggested reviewers

• ogzhanolguncu
• perkinsjr
• chronark

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ba2b119 and 15bc099.

📒 Files selected for processing (3)

• apps/dashboard/lib/trpc/routers/org/getOrganizationMemberList.ts (1 hunks)
• apps/dashboard/lib/trpc/trpc.ts (0 hunks)
• apps/docs/docs.json (6 hunks)

💤 Files with no reviewable changes (1)

• apps/dashboard/lib/trpc/trpc.ts

✅ Files skipped from review due to trivial changes (1)

• apps/docs/docs.json

🚧 Files skipped from review as they are similar to previous changes (1)

• apps/dashboard/lib/trpc/routers/org/getOrganizationMemberList.ts

⏰ Context from checks skipped due to timeout of 90000ms (17)

• GitHub Check: autofix
• GitHub Check: Test Go API Local / Test (Shard 8/8)
• GitHub Check: Test Go API Local / Test (Shard 6/8)
• GitHub Check: Test Agent Local / test_agent_local
• GitHub Check: Test Go API Local / Test (Shard 3/8)
• GitHub Check: Test Go API Local / Test (Shard 4/8)
• GitHub Check: Test API / API Test Local
• GitHub Check: Test Packages / Test ./packages/rbac
• GitHub Check: Test Packages / Test ./packages/api
• GitHub Check: Test Packages / Test ./packages/hono
• GitHub Check: Test Packages / Test ./internal/billing
• GitHub Check: Test Packages / Test ./internal/id
• GitHub Check: Test Packages / Test ./internal/clickhouse
• GitHub Check: Test Packages / Test ./internal/encryption
• GitHub Check: Test Packages / Test ./internal/hash
• GitHub Check: Build / Build
• GitHub Check: Analyze (javascript-typescript)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏