fix: oauth from request.url by perkinsjr · Pull Request #3065 · unkeyed/unkey

perkinsjr · 2025-03-31T23:06:06Z

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
Enhancement (small improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How should this be tested?

Test A
Test B

Checklist

Required

Appreciated

If a UI change was made: Added a screen recording or screenshots to this PR
Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

Refactor
- Revised the process for retrieving the base URL during authentication handling. The update now derives the base URL directly from the request, ensuring that redirection, error management, and cookie settings continue to operate as expected.

vercel · 2025-03-31T23:06:10Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 31, 2025 11:06pm
engineering	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 31, 2025 11:06pm
play	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 31, 2025 11:06pm
www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 31, 2025 11:06pm

changeset-bot · 2025-03-31T23:06:11Z

⚠️ No Changeset found

Latest commit: 7f1aab5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-03-31T23:06:14Z

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request modifies the method of obtaining the base URL in the GET function of the SSO callback route. The previous implementation imported a utility function (getBaseUrl) to determine the base URL. Now, the function directly creates a new URL using the incoming request’s URL and extracts the origin property. The authentication result handling, redirection, error management, and cookie setting remain unchanged.

Changes

File Path	Change Summary
`apps/dashboard/.../sso-callback/route.ts`	Removed the import of `getBaseUrl` from the utility library and replaced it by directly obtaining the base URL via `new URL(request.url).origin`.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Route as "RouteHandler (GET)"
    
    Client->>Route: Send GET request to /sso-callback route
    Route->>Route: Extract base URL using new URL(request.url).origin
    Route->>Route: Process authentication and determine redirection
    Route-->>Client: Issue redirect response with auth results

Possibly related PRs

fix: Update code to infer Vercel URL for WorkOS redirect #3061: This PR involves changes to base URL handling by adding an import for getBaseUrl and modifying the retrieval method, indicating a direct code-level relationship with the current modifications.

Suggested reviewers

chronark
ogzhanolguncu
mcstepp

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 60c0fef and 7f1aab5.

📒 Files selected for processing (1)

apps/dashboard/app/auth/sso-callback/[[...sso-callback]]/route.ts (1 hunks)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-03-31T23:06:16Z

Thank you for following the naming conventions for pull request titles! 🙏

oauth from request.url

7f1aab5

perkinsjr requested review from chronark, mcstepp and ogzhanolguncu as code owners March 31, 2025 23:06

perkinsjr merged commit 368f112 into main Mar 31, 2025
33 of 36 checks passed

perkinsjr deleted the oauth-fix branch March 31, 2025 23:06

p6l-richard mentioned this pull request Apr 4, 2025

feat(billing): update the keyword-research #3077

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: oauth from request.url#3065

fix: oauth from request.url#3065
perkinsjr merged 1 commit intomainfrom
oauth-fix

perkinsjr commented Mar 31, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Mar 31, 2025

Uh oh!

changeset-bot bot commented Mar 31, 2025

Uh oh!

coderabbitai bot commented Mar 31, 2025 •

edited

Loading

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

perkinsjr commented Mar 31, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

How should this be tested?

Checklist

Required

Appreciated

Summary by CodeRabbit

Uh oh!

vercel bot commented Mar 31, 2025

Uh oh!

changeset-bot bot commented Mar 31, 2025

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

perkinsjr commented Mar 31, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 31, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Mar 31, 2025 •

edited

Loading