Conversation
Fixing terms
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThe changes update the Changes
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/dashboard/app/auth/layout.tsx (1)
112-112: LGTM! Changing to absolute URLs ensures consistent policy access.The change from relative URLs to absolute URLs for the Terms of Service and Privacy Policy links is appropriate. This ensures users always access the most up-to-date policies on the main Unkey website, regardless of which environment they're in.
Consider adding
target="_blank" rel="noopener noreferrer"to these links to open them in a new tab, which would improve user experience by not interrupting the authentication flow:-<Link className="underline" href="https://www.unkey.com/policies/terms"> +<Link className="underline" href="https://www.unkey.com/policies/terms" target="_blank" rel="noopener noreferrer">-<Link className="underline" href="https://www.unkey.com/policies/privacy"> +<Link className="underline" href="https://www.unkey.com/policies/privacy" target="_blank" rel="noopener noreferrer">Also applies to: 116-116
Fixing terms
What does this PR do?
Fixes # (issue)
If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists
Type of change
How should this be tested?
Checklist
Required
pnpm buildpnpm fmtconsole.logsgit pull origin mainAppreciated
Summary by CodeRabbit