Skip to content

Fix URLs for terms#3053

Merged
perkinsjr merged 3 commits intomainfrom
perkinsjr-patch-1
Mar 31, 2025
Merged

Fix URLs for terms#3053
perkinsjr merged 3 commits intomainfrom
perkinsjr-patch-1

Conversation

@perkinsjr
Copy link
Member

@perkinsjr perkinsjr commented Mar 31, 2025

Fixing terms

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

  • New Features
    • Updated navigation links for the Terms of Service and Privacy Policy. Users clicking these links will be redirected to the official external pages to view the policy details online. This update modifies the navigation flow and ensures access to the latest externally hosted policy content across our platform.
    • Links now open in a new tab for improved user experience and security.

Fixing terms
@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2025

⚠️ No Changeset found

Latest commit: f1bb702

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard 🛑 Canceled (Inspect) Mar 31, 2025 1:39pm
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 1:39pm
play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 1:39pm
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 1:39pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 31, 2025

📝 Walkthrough

Walkthrough

The changes update the AuthenticatedLayout component in the layout.tsx file by modifying the URLs in two <Link> components. The relative paths for the Terms of Service and Privacy Policy have been replaced with absolute URLs pointing to the Unkey website. Additionally, the <Link> components now include target="_blank" and rel="noopener noreferrer" attributes for enhanced security. No other parts of the component were changed.

Changes

File(s) Change Summary
apps/dashboard/app/auth/layout.tsx Updated <Link> components to use absolute URLs for Terms of Service (https://www.unkey.com/policies/terms) and Privacy Policy (https://www.unkey.com/policies/privacy), and added target="_blank" and rel="noopener noreferrer" attributes.

Suggested labels

Bug, 🕹️ oss.gg

Suggested reviewers

  • mcstepp
  • chronark
  • ogzhanolguncu
  • MichaelUnkey

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b903a65 and f1bb702.

📒 Files selected for processing (1)
  • apps/dashboard/app/auth/layout.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/dashboard/app/auth/layout.tsx

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Here is an example:

<type>[optional scope]: <description>
fix: I fixed something for Unkey

Details:

No release type found in pull request title "Fix URLs for terms". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@perkinsjr perkinsjr marked this pull request as ready for review March 31, 2025 13:31
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/dashboard/app/auth/layout.tsx (1)

112-112: LGTM! Changing to absolute URLs ensures consistent policy access.

The change from relative URLs to absolute URLs for the Terms of Service and Privacy Policy links is appropriate. This ensures users always access the most up-to-date policies on the main Unkey website, regardless of which environment they're in.

Consider adding target="_blank" rel="noopener noreferrer" to these links to open them in a new tab, which would improve user experience by not interrupting the authentication flow:

-<Link className="underline" href="https://www.unkey.com/policies/terms">
+<Link className="underline" href="https://www.unkey.com/policies/terms" target="_blank" rel="noopener noreferrer">
-<Link className="underline" href="https://www.unkey.com/policies/privacy">
+<Link className="underline" href="https://www.unkey.com/policies/privacy" target="_blank" rel="noopener noreferrer">

Also applies to: 116-116

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 14dc756 and b903a65.

📒 Files selected for processing (1)
  • apps/dashboard/app/auth/layout.tsx (1 hunks)

@perkinsjr perkinsjr merged commit baf3176 into main Mar 31, 2025
28 of 36 checks passed
@perkinsjr perkinsjr deleted the perkinsjr-patch-1 branch March 31, 2025 13:36
@vercel vercel bot temporarily deployed to Preview – engineering March 31, 2025 13:37 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard March 31, 2025 13:38 Inactive
@vercel vercel bot temporarily deployed to Preview – www March 31, 2025 13:38 Inactive
@vercel vercel bot temporarily deployed to Preview – play March 31, 2025 13:39 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant