fix(api): Disable otel rpc server attributes#3043
Merged
Conversation
imeyer
requested review from
MichaelUnkey,
chronark,
mcstepp,
ogzhanolguncu and
perkinsjr
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
📝 WalkthroughWalkthroughThis change updates the configuration of telemetry interceptors by adding the Changes
Sequence Diagram(s)Service Peer Creation FlowsequenceDiagram
actor Client as "Caller"
participant S as "service.newPeer"
participant I as "otelconnect.NewInterceptor"
Client->>S: newPeer(ctx, key)
S->>I: NewInterceptor(tracerProvider, WithoutServerPeerAttributes)
alt Success
I-->>S: interceptor instance
S-->>Client: returns peer
else Error
I-->>S: error
S-->>Client: returns error
end
RPC Initialization FlowsequenceDiagram
actor Client as "Caller"
participant R as "rpc.New"
participant I as "otelconnect.NewInterceptor"
Client->>R: New()
R->>I: NewInterceptor(tracerProvider, trustRemoteOptions, WithoutServerPeerAttributes)
alt Success
I-->>R: interceptor instance
R-->>Client: returns service instance
else Error
I-->>R: error
R-->>Client: returns error
end
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
|
Thank you for following the naming conventions for pull request titles! 🙏 |
By default OpenTelemetry RPC includes peer ports and names which increase metric cardinality by a significant amount. Setting the option WithoutServerPeerAttributes() on the interceptor removes those attributes. Signed-off-by: Ian Meyer (imeyer) <k@imeyer.io>
imeyer
force-pushed
the
otelconnect-remove-server-peer-attributes
branch
from
70dc0f9 to
f0fe3ec
Compare
chronark
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default OpenTelemetry RPC includes peer ports and names which increase metric cardinality by a significant amount. Setting the option WithoutServerPeerAttributes() on the interceptor removes those attributes.
Summary by CodeRabbit