Skip to content

fix: insert quota for new initial workspaces#3007

Merged
chronark merged 2 commits intomainfrom
insert-quota
Mar 21, 2025
Merged

fix: insert quota for new initial workspaces#3007
chronark merged 2 commits intomainfrom
insert-quota

Conversation

@chronark
Copy link
Collaborator

@chronark chronark commented Mar 21, 2025

Summary by CodeRabbit

  • New Features

    • Enhanced the workspace creation process by automatically assigning a "Free" tier with preset usage limits.
    • Introduced a centralized configuration for free-tier quotas to ensure consistent quota assignment.
  • Refactor

    • Streamlined quota management by replacing hardcoded values with a dynamic configuration, improving maintainability.

@vercel
Copy link

vercel bot commented Mar 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 7:39am
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 7:39am
play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 7:39am
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 7:39am

@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2025

⚠️ No Changeset found

Latest commit: 845fe96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 21, 2025

📝 Walkthrough

Walkthrough

This pull request centralizes quota configuration by removing local declarations of freeTierQuotas and importing it from a new dedicated module. The changes affect multiple parts of the application: the Stripe webhook handler, the workspace creation page, and the workspace creation API, where the workspace is now assigned a "Free" tier and associated quota values dynamically. A new file is introduced to define the quota limits used during these operations.

Changes

File(s) Change Summary
apps/dashboard/app/api/webhooks/stripe/route.ts, apps/dashboard/app/new/page.tsx, apps/dashboard/lib/trpc/routers/workspace/create.ts Removed local definitions and hardcoded quota values; integrated imported freeTierQuotas from @/lib/quotas. Additionally, renamed a variable (from personalWorkspace to workspace), added a new "Free" tier field, and updated database insertion logic to use dynamic quota configuration.
apps/dashboard/lib/quotas.ts New file added that exports the freeTierQuotas constant. This object defines quota limits (150,000 requests per month, 7 days logs retention, 30 days audit logs retention, and team: false) by omitting the workspaceId property from the Quotas type.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant FP as Frontend (page.tsx)
    participant TRPC as Workspace API (create.ts)
    participant DB as Database
    participant Q as Quotas Module

    U->>FP: Initiate workspace creation
    FP->>TRPC: Submit creation request with user info
    TRPC->>DB: Insert workspace record (includes tier "Free")
    TRPC->>Q: Import freeTierQuotas configuration
    TRPC->>DB: Insert quota record (spreading freeTierQuotas)
    DB-->>TRPC: Confirm insertions
    TRPC-->>FP: Return creation result
Loading

Possibly related PRs

  • feat: cancel subscriptions at the end of the period #2944: The changes in the main PR are related to the modifications of the freeTierQuotas variable, which is also referenced in the retrieved PR, specifically in the context of how quotas are handled during workspace creation and subscription management.

Suggested labels

Bug, 🕹️ oss.gg, :joystick: 150 points, hacktoberfest

Suggested reviewers

  • mcstepp
  • perkinsjr
  • ogzhanolguncu
  • MichaelUnkey

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 845fe96 and efc9515.

📒 Files selected for processing (1)
  • apps/dashboard/lib/trpc/routers/workspace/create.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/dashboard/lib/trpc/routers/workspace/create.ts
⏰ Context from checks skipped due to timeout of 90000ms (9)
  • GitHub Check: autofix
  • GitHub Check: Test Go API Local / Test (Shard 4/8)
  • GitHub Check: Test Go API Local / Test (Shard 5/8)
  • GitHub Check: Test Packages / Test ./internal/clickhouse
  • GitHub Check: Test Agent Local / test_agent_local
  • GitHub Check: Test Packages / Test ./internal/hash
  • GitHub Check: Test API / API Test Local
  • GitHub Check: Build / Build
  • GitHub Check: Analyze (javascript-typescript)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2025

Thank you for following the naming conventions for pull request titles! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant