fix: layout shifts and missing props by ogzhanolguncu · Pull Request #3006 · unkeyed/unkey

ogzhanolguncu · 2025-03-20T20:07:16Z

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
Enhancement (small improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How should this be tested?

Test A
Test B

Checklist

Required

Appreciated

If a UI change was made: Added a screen recording or screenshots to this PR
Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

Style
- Enhanced navigation links by marking "APIs" and "Ratelimits" as active with improved formatting.
- Refined vertical spacing in log controls for a more compact display.
- Applied a minimum height to the navigation bar for consistent layout.

changeset-bot · 2025-03-20T20:07:21Z

⚠️ No Changeset found

Latest commit: 9995789

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-03-20T20:07:21Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 20, 2025 8:11pm
engineering	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 20, 2025 8:11pm
play	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 20, 2025 8:11pm
www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 20, 2025 8:11pm

coderabbitai · 2025-03-20T20:07:25Z

📝 Walkthrough

Walkthrough

This pull request updates the visual state and styling of several dashboard components. It adds an active prop to Navbar.Breadcrumbs.Link in both the APIs and Ratelimits navigation files—adjusting text placement to a new line—and reduces the vertical padding (from py-2 to py-1) in two logs control components. Additionally, it enforces a consistent minimum height on the navbar by adding a specific CSS class.

Changes

File(s)	Change Summary
`apps/dashboard/app/(app)/apis/navigation.tsx` `apps/dashboard/app/(app)/ratelimits/navigation.tsx`	Added an `active` prop to the `Navbar.Breadcrumbs.Link` component with text moved to a new line to better indicate the active navigation state.
`apps/dashboard/app/(app)/logs/components/controls/index.tsx` `apps/dashboard/app/(app)/ratelimits/[namespaceId]/logs/components/controls/index.tsx`	Reduced vertical padding on a `div` element from `py-2` to `py-1`, adjusting the spacing in the logs controls.
`apps/dashboard/components/navigation/navbar.tsx`	Added the `min-h-[65px]` class to the `<nav>` element, ensuring the navigation bar maintains a consistent minimum height.

Possibly related PRs

fix: Ratelimit identifier component changes #2712: Introduces similar modifications by adding an active prop to the Navbar.Breadcrumbs.Link component for a different link.
fix: dashboard icon flickering #2170: Contains analogous updates to the Navbar.Breadcrumbs.Link component in another context, reflecting a direct code-level connection.
chore: add internal package called @unkey/vault #2279: Adds an active prop to the Navbar.Breadcrumbs.Link for the "Ratelimits" link, aligning closely with the modifications in this PR.

Suggested labels

Bug, Improvement, Needs Approval

Suggested reviewers

mcstepp
chronark
perkinsjr

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f12539 and 9995789.

📒 Files selected for processing (5)

apps/dashboard/app/(app)/apis/navigation.tsx (1 hunks)
apps/dashboard/app/(app)/logs/components/controls/index.tsx (1 hunks)
apps/dashboard/app/(app)/ratelimits/[namespaceId]/logs/components/controls/index.tsx (1 hunks)
apps/dashboard/app/(app)/ratelimits/navigation.tsx (1 hunks)
apps/dashboard/components/navigation/navbar.tsx (1 hunks)

🧰 Additional context used

🧬 Code Definitions (2)

apps/dashboard/app/(app)/apis/navigation.tsx (1)

apps/dashboard/components/navigation/navbar.tsx (1) (1)

Navbar (44-57)

apps/dashboard/app/(app)/ratelimits/navigation.tsx (1)

apps/dashboard/components/navigation/navbar.tsx (1) (1)

Navbar (44-57)

⏰ Context from checks skipped due to timeout of 90000ms (12)

GitHub Check: Test Packages / Test ./packages/nextjs
GitHub Check: Test Packages / Test ./internal/resend
GitHub Check: Test Packages / Test ./packages/api
GitHub Check: Test Packages / Test ./packages/cache
GitHub Check: Test Packages / Test ./packages/rbac
GitHub Check: Test Agent Local / test_agent_local
GitHub Check: Test Packages / Test ./internal/keys
GitHub Check: Test Go API Local / Test
GitHub Check: Test API / API Test Local
GitHub Check: Build / Build
GitHub Check: autofix
GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (5)

apps/dashboard/app/(app)/logs/components/controls/index.tsx (1)

11-11: Great vertical spacing adjustment with minimum height.

Reducing the vertical padding from py-2 to py-1 and adding the min-h-10 class helps maintain consistent spacing while preventing layout shifts, which aligns well with the PR objectives.

apps/dashboard/app/(app)/ratelimits/[namespaceId]/logs/components/controls/index.tsx (1)

10-10: Good consistency with logs controls.

This change mirrors the adjustment in the main logs controls component, ensuring consistent styling between both log control interfaces while preventing layout shifts.

apps/dashboard/components/navigation/navbar.tsx (1)

49-49: Excellent addition of minimum height constraint.

Adding min-h-[65px] to the navbar ensures it maintains a consistent height regardless of content, preventing unwanted layout shifts during navigation or state changes.

apps/dashboard/app/(app)/ratelimits/navigation.tsx (1)

10-12: Correctly added the missing active prop.

Adding the active prop to the breadcrumb link properly indicates the current navigation state, improving the user interface by visually highlighting the current section. Also, the text formatting on a separate line improves code readability.

apps/dashboard/app/(app)/apis/navigation.tsx (1)

16-18: Added active state to navigation link, improving UI consistency.

Adding the active prop to the Navbar.Breadcrumbs.Link component correctly indicates the current page in the navigation. This change aligns with similar modifications in other navigation components and helps users understand their current location within the application.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-03-20T20:07:28Z

Thank you for following the naming conventions for pull request titles! 🙏

ogzhanolguncu · 2025-03-20T20:08:08Z

A couple of layout shifts I've just noticed and some missing navbar props

* fix: layout shift * fix: missing active tags

* feat: add usage-insight on the desktop-sidebar * remove console.log * refactor: improve code consistency and formatting across multiple files * fix: keep only the progress circle, remove the particle effect, keep the card always open * refactor: simplify layout and desktop sidebar components, remove unused billing logic * feat(billing): add usage fetching hook and TRPC query for billing usage data * fix: update workspace creation logic to set plan to 'free' and improve error handling * fix: remove unnecessary console log for usage query fetching * refactor: adjust padding and height in usage insights component for improved layout * fix: update plan type in usage insights to handle workspace tier and default to 'Free' * [autofix.ci] apply automated fixes * refactor: improve code readability and formatting in usage insights component * refactor: remove Particles component and relocate useMousePosition hook * refactor: enhance code formatting and readability in desktop sidebar component * fix: remove use-mouse hook * pnpm fmt * pnpm-lock fix * refactor: update usage insights to use 'tier' instead of 'plan' and simplify loading state handling * fix: remove outdated and wrong quota check (#3000) we now have proper quotas, so this check is redundand. If a workspace is disabled, there is already a warning in the root layout to contact us. * Update README.md (#3002) Fix Invalid URL of "Read our blog post" * feat: sidebar (#3003) * feat: add new sidebar * fix: icon * fix: padding issues * feat: add new sidebar * fix: ui issues * chore: clenaup * chore: remove unused button * fix: collapse issue * fix: ui issues * chore: remove unused files * fix: layout shifts and missing props (#3006) * fix: layout shift * fix: missing active tags * refactor: clean up imports and improve layout component structure * pnpm fmt * refactor: simplify usage query options in useFetchUsage hook * pnpm fmt * fix: broken lock * fix: quotas rename to quota This fixes the incorrect usage max issue * fix: refetch usage --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Oğuzhan Olguncu <21091016+ogzhanolguncu@users.noreply.github.com> Co-authored-by: James P <jamesperkins@hey.com> Co-authored-by: Andreas Thomas <dev@chronark.com> Co-authored-by: okuma <49895482+kumachan99@users.noreply.github.com> Co-authored-by: ogzhanolguncu <ogzhan11@gmail.com>

ogzhanolguncu added 2 commits March 20, 2025 22:57

fix: layout shift

a2e622e

fix: missing active tags

9995789

ogzhanolguncu requested review from chronark, mcstepp and perkinsjr as code owners March 20, 2025 20:07

vercel bot deployed to Preview – engineering March 20, 2025 20:07 View deployment

vercel bot deployed to Preview – www March 20, 2025 20:07 View deployment

vercel bot deployed to Preview – play March 20, 2025 20:08 View deployment

vercel bot deployed to Preview – dashboard March 20, 2025 20:11 View deployment

perkinsjr approved these changes Mar 20, 2025

View reviewed changes

ogzhanolguncu added this pull request to the merge queue Mar 20, 2025

Merged via the queue into main with commit bb7aa9d Mar 20, 2025
30 of 31 checks passed

ogzhanolguncu deleted the logs-style-fix branch March 20, 2025 20:46

revogabe pushed a commit to revogabe/unkey that referenced this pull request Mar 21, 2025

fix: layout shifts and missing props (unkeyed#3006)

a41ec8a

* fix: layout shift * fix: missing active tags

coderabbitai bot mentioned this pull request Apr 2, 2025

feat: updated api settings page #3072

Merged

18 tasks

p6l-richard mentioned this pull request Apr 4, 2025

feat(billing): update the keyword-research #3077

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: layout shifts and missing props#3006

fix: layout shifts and missing props#3006
ogzhanolguncu merged 2 commits intomainfrom
logs-style-fix

ogzhanolguncu commented Mar 20, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Mar 20, 2025

Uh oh!

vercel bot commented Mar 20, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 20, 2025 •

edited

Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Mar 20, 2025 •

edited

Loading

Uh oh!

ogzhanolguncu commented Mar 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ogzhanolguncu commented Mar 20, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

How should this be tested?

Checklist

Required

Appreciated

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Mar 20, 2025

⚠️ No Changeset found

Uh oh!

vercel bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ogzhanolguncu commented Mar 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ogzhanolguncu commented Mar 20, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Mar 20, 2025 •

edited

Loading

coderabbitai bot commented Mar 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Mar 20, 2025 •

edited

Loading