fix: missing permissions and roles

[ogzhanolguncu]

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Chore (refactoring code, technical debt, workflow improvements)
• Enhancement (small improvements)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How should this be tested?

• Test A
• Test B

Checklist

Required

• Filled out the "How to test" section in this PR
• Read Contributing Guide
• Self-reviewed my own code
• Commented on my code in hard-to-understand areas
• Ran pnpm build
• Ran pnpm fmt
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

• New Features

  • Improved filtering to display only active roles and keys, ensuring the UI shows accurate counts.
  • Added a clear on-screen message when no permissions are configured for a role.

• Refactor

  • Streamlined the role retrieval process with enhanced permission count calculations for improved display accuracy.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 17, 2025 4:04pm
engineering	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 17, 2025 4:04pm
play	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 17, 2025 4:04pm
www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 17, 2025 4:04pm

[changeset-bot]

⚠️ No Changeset found

Latest commit: 538e037

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This pull request introduces changes to how roles and their permissions are processed and rendered in the Dashboard. In the permissions components, new optional properties (id and deletedAt) are added to role objects, along with filtering logic that only retains active (non-deleted) roles for display and counting. In the roles components, role retrieval is restructured to use data from the workspace, and a new permissionCount property is added. Additionally, a conditional rendering is implemented to inform users when no permissions exist for a role.

Changes

Files	Change Summary
apps/dashboard/app/(app)/authorization/permissions/[permissionId]/settings-client.tsx apps/dashboard/app/(app)/authorization/permissions/page.tsx	Added optional properties id and deletedAt to role objects. Introduced filtering logic (activeRoles and using an activeRoleIds set) to exclude inactive or deleted roles from the connected roles and keys counts.
apps/dashboard/app/(app)/authorization/roles/[roleId]/settings-client.tsx apps/dashboard/app/(app)/authorization/roles/page.tsx	Implemented conditional rendering in the role settings to display a fallback message when no permissions are configured. Restructured role retrieval to derive roles from the workspace with enhanced filtering using an activePermissionIds set and added a permissionCount property.

Sequence Diagram(s)

sequenceDiagram
    participant PermissionsSettings as Permissions Settings Component
    participant RolesData as Roles Data
    participant UI as User Interface

    PermissionsSettings->>RolesData: Iterate over roles
    RolesData-->>PermissionsSettings: Return role objects (with id and deletedAt)
    PermissionsSettings->>PermissionsSettings: Filter roles (id exists & deletedAt is null/undefined)
    PermissionsSettings->>UI: Update connected roles and keys count display

Loading

sequenceDiagram
    participant RoleClient as Role Settings Component
    participant SortedPerms as sortedNestedPermissions
    participant UI as User Interface

    RoleClient->>SortedPerms: Check if any permission keys exist
    alt Permissions exist
        RoleClient->>UI: Render Tree component with permissions
    else No permissions
        RoleClient->>UI: Render message indicating no permissions configured
    end

Loading

Possibly related PRs

• fix: updating a key's action should not work when it has been deleted #2897: The changes involve adding a deletedAt property and filtering based on it, which directly relates to this PR's modifications for handling soft-deleted keys.

Suggested labels

Bug, Good first issue, 🕹️ oss.gg, :joystick: 150 points, hacktoberfest

Suggested reviewers

• mcstepp
• chronark
• perkinsjr

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3012bec and 538e037.

📒 Files selected for processing (4)

• apps/dashboard/app/(app)/authorization/permissions/[permissionId]/settings-client.tsx (3 hunks)
• apps/dashboard/app/(app)/authorization/permissions/page.tsx (1 hunks)
• apps/dashboard/app/(app)/authorization/roles/[roleId]/settings-client.tsx (1 hunks)
• apps/dashboard/app/(app)/authorization/roles/page.tsx (3 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏