Skip to content

fix: small style change for blog#2846

Merged
MichaelUnkey merged 2 commits intomainfrom
eng-1614-mobile-blog-tags
Jan 28, 2025
Merged

fix: small style change for blog#2846
MichaelUnkey merged 2 commits intomainfrom
eng-1614-mobile-blog-tags

Conversation

@MichaelUnkey
Copy link
Collaborator

@MichaelUnkey MichaelUnkey commented Jan 28, 2025

What does this PR do?

Eng-1614

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

Blog slug looks ok on for author name alignment

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

  • Style
    • Refined layout and styling for blog article author and publication date sections
    • Adjusted padding and alignment of author name and publication date
    • Modified text formatting for publication date display
  • Chores
    • Added a semicolon for consistency in error handling code
    • Reformatted error message in the deleteKeys mutation

@linear
Copy link

linear bot commented Jan 28, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: 74d3a7e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 3:12am
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 3:12am
play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 3:12am
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 3:12am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 28, 2025

📝 Walkthrough

Walkthrough

The pull request introduces several modifications to the BlogArticleWrapper component in apps/www/app/blog/[slug]/page.tsx. The changes primarily involve adjustments to the layout and styling of the author and publication date sections. These modifications include alterations to padding, width, alignment, and text styling, enhancing the visual presentation of the blog article's metadata without affecting its core functionality.

Changes

File Change Summary
apps/www/app/blog/[slug]/page.tsx - Reduced author name paragraph padding from pt-2 to pt-1
- Added w-full and justify-end classes to publication date container
- Changed publication date label from text-xs to text-nowrap
apps/dashboard/lib/trpc/routers/key/delete.ts - Added a semicolon to console.error(err)
- Reformatted error message in TRPCError by removing the period

Suggested labels

Bug, Needs Approval

Suggested reviewers

  • mcstepp
  • chronark
  • perkinsjr
  • MichaelUnkey

Possibly related PRs

  • fix: UI for update and create key #2795: The changes in this PR involve modifications to the UpdateKeyRemaining and CreateKey components, specifically enhancing the handling of refill intervals and validation logic, which is directly related to the adjustments made in the BlogArticleWrapper component regarding layout and styling.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 238ad41 and 74d3a7e.

📒 Files selected for processing (1)
  • apps/dashboard/lib/trpc/routers/key/delete.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • apps/dashboard/lib/trpc/routers/key/delete.ts
⏰ Context from checks skipped due to timeout of 90000ms (18)
  • GitHub Check: Test Packages / Test ./packages/rbac
  • GitHub Check: Test Packages / Test ./packages/nextjs
  • GitHub Check: Test Packages / Test ./packages/hono
  • GitHub Check: Test Packages / Test ./packages/cache
  • GitHub Check: Test Packages / Test ./packages/api
  • GitHub Check: Test Packages / Test ./internal/clickhouse
  • GitHub Check: Test Packages / Test ./internal/resend
  • GitHub Check: Test Packages / Test ./internal/keys
  • GitHub Check: Test Packages / Test ./internal/id
  • GitHub Check: Test GO API Local / test_agent_local
  • GitHub Check: Test Packages / Test ./internal/hash
  • GitHub Check: Test Packages / Test ./internal/encryption
  • GitHub Check: Test Packages / Test ./internal/billing
  • GitHub Check: Test Agent Local / test_agent_local
  • GitHub Check: Build / Build
  • GitHub Check: Test API / API Test Local
  • GitHub Check: autofix
  • GitHub Check: Analyze (javascript-typescript)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Thank you for following the naming conventions for pull request titles! 🙏

@vercel vercel bot temporarily deployed to Preview – dashboard January 28, 2025 03:08 Inactive
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/www/app/blog/[slug]/page.tsx (1)

Line range hint 183-192: LGTM! Consider consolidating text-nowrap classes.

The layout changes create a well-balanced presentation. For consistency, consider moving the text-nowrap class to a parent element since both the label and date value use it.

-                <div className="flex flex-col h-full w-full justify-end">
+                <div className="flex flex-col h-full w-full justify-end text-nowrap">
                   {" "}
-                  <p className="text-nowrap text-white/50">Published on</p>
+                  <p className="text-white/50">Published on</p>
                   <div className="flex mt-2 sm:mt-6 md:mt-5">
                     <time
                       dateTime={post.date}
-                      className="inline-flex items-center text-white text-nowrap"
+                      className="inline-flex items-center text-white"
                     >
                       {format(parseISO(post.date), "MMM dd, yyyy")}
                     </time>
                   </div>
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3f8db32 and 238ad41.

📒 Files selected for processing (1)
  • apps/www/app/blog/[slug]/page.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (18)
  • GitHub Check: Test Packages / Test ./packages/rbac
  • GitHub Check: Test Packages / Test ./packages/nextjs
  • GitHub Check: Test Packages / Test ./packages/hono
  • GitHub Check: Test Packages / Test ./packages/cache
  • GitHub Check: Test Packages / Test ./packages/api
  • GitHub Check: Test Packages / Test ./internal/clickhouse
  • GitHub Check: Test GO API Local / test_agent_local
  • GitHub Check: Test Packages / Test ./internal/resend
  • GitHub Check: Test Packages / Test ./internal/keys
  • GitHub Check: Test Packages / Test ./internal/id
  • GitHub Check: Test Packages / Test ./internal/hash
  • GitHub Check: Test Packages / Test ./internal/encryption
  • GitHub Check: Test Packages / Test ./internal/billing
  • GitHub Check: Test API / API Test Local
  • GitHub Check: Test Agent Local / test_agent_local
  • GitHub Check: Build / Build
  • GitHub Check: autofix
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
apps/www/app/blog/[slug]/page.tsx (1)

178-180: LGTM! Clean implementation of author name alignment.

The padding adjustment and text wrapping prevention help maintain consistent alignment with the avatar.

@vercel vercel bot temporarily deployed to Preview – www January 28, 2025 03:10 Inactive
@vercel vercel bot temporarily deployed to Preview – engineering January 28, 2025 03:10 Inactive
@vercel vercel bot temporarily deployed to Preview – play January 28, 2025 03:11 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard January 28, 2025 03:12 Inactive
@MichaelUnkey MichaelUnkey added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit ffc5e34 Jan 28, 2025
24 checks passed
@MichaelUnkey MichaelUnkey deleted the eng-1614-mobile-blog-tags branch January 28, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants