Skip to content

chore: Update footer.tsx#2735

Merged
perkinsjr merged 3 commits intomainfrom
perkinsjr-patch-2
Dec 10, 2024
Merged

chore: Update footer.tsx#2735
perkinsjr merged 3 commits intomainfrom
perkinsjr-patch-2

Conversation

@perkinsjr
Copy link
Member

@perkinsjr perkinsjr commented Dec 10, 2024

Add status page

What does this PR do?

Adds a link to the status page, to solve this problem. We can do something in the future if we change providers or want to create a component (IMO overkill)

Fixes #2185

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

  • New Features
    • Added a "Status Page" navigation link in the footer under the "Company" section, directing users to the status page.

Add status page
@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: f707249

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 5:22pm
play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 5:22pm
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 5:22pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
dashboard ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 5:22pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes introduce a new navigation link titled "Status Page" in the "Company" section of the navigation array within the footer.tsx file. The link has properties including a title, an external URL pointing to "https://status.unkey.com", and does not affect existing links or their properties. The overall structure and functionality of the Footer component remain unchanged.

Changes

File Path Change Summary
apps/www/components/footer/footer.tsx Added a new navigation link "Status Page" with href set to "https://status.unkey.com" and external set to true.
apps/workflows/src/workflows/count_keys_per_keyspace.ts Reformatted await step.do calls in the CountKeys class for improved readability without changing logic.

Assessment against linked issues

Objective Addressed Explanation
Showcase Status Page in navigation (#2185)

Possibly related PRs

Suggested labels

Good first issue, 🕹️ oss.gg, :joystick: 150 points, hacktoberfest

Suggested reviewers

  • mcstepp
  • chronark
  • MichaelUnkey
  • perkinsjr

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 117f49e and f707249.

📒 Files selected for processing (2)
  • apps/workflows/src/workflows/count_keys_per_keyspace.ts (1 hunks)
  • apps/www/components/footer/footer.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • apps/workflows/src/workflows/count_keys_per_keyspace.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/www/components/footer/footer.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@vercel vercel bot temporarily deployed to Preview – dashboard December 10, 2024 17:13 Inactive
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
apps/www/components/footer/footer.tsx (1)

40-43: Consider future enhancements for better status visibility.

While this change successfully adds the status page link, consider these future enhancements from issue #2185:

  1. Add a visual status indicator (green/orange/red) next to the link
  2. Improve search indexing for the status page

Would you like me to propose a design for implementing the status indicator feature?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 2f6f7a9 and 9faeba7.

📒 Files selected for processing (1)
  • apps/www/components/footer/footer.tsx (1 hunks)
🔇 Additional comments (2)
apps/www/components/footer/footer.tsx (2)

40-43: The integration with existing footer structure is clean.

The new link seamlessly integrates with the existing navigation structure while maintaining type safety and proper external link handling.


40-43: LGTM! The status page link is properly configured.

The new navigation link follows the established pattern and correctly sets the external flag for the status page URL.

✅ Verification successful

Status page URL is accessible and properly configured

The status page URL (https://status.unkey.com) is live and returns a successful HTTP 200 response with proper security headers, confirming it's a valid and secure endpoint.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify the status page URL is accessible
curl -I https://status.unkey.com

Length of output: 5772

@github-actions github-actions bot added Bug Something isn't working Needs Approval Needs approval from Unkey labels Dec 10, 2024
@vercel vercel bot temporarily deployed to Preview – play December 10, 2024 17:17 Inactive
@vercel vercel bot temporarily deployed to Preview – engineering December 10, 2024 17:17 Inactive
@vercel vercel bot temporarily deployed to Preview – engineering December 10, 2024 17:20 Inactive
@perkinsjr perkinsjr removed the Needs Approval Needs approval from Unkey label Dec 10, 2024
@perkinsjr perkinsjr enabled auto-merge December 10, 2024 17:20
@vercel vercel bot temporarily deployed to Preview – play December 10, 2024 17:20 Inactive
@vercel vercel bot temporarily deployed to Preview – www December 10, 2024 17:22 Inactive
@perkinsjr perkinsjr disabled auto-merge December 10, 2024 17:24
@perkinsjr perkinsjr merged commit 7c8b7fa into main Dec 10, 2024
@perkinsjr perkinsjr deleted the perkinsjr-patch-2 branch December 10, 2024 17:24
@coderabbitai coderabbitai bot mentioned this pull request Dec 12, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🕹️] Showcase Status Page somewhere

1 participant