Skip to content

feat: add beta tag to sidebar for logs#2716

Merged
ogzhanolguncu merged 1 commit intomainfrom
update-sidebar
Dec 6, 2024
Merged

feat: add beta tag to sidebar for logs#2716
ogzhanolguncu merged 1 commit intomainfrom
update-sidebar

Conversation

@ogzhanolguncu
Copy link
Contributor

@ogzhanolguncu ogzhanolguncu commented Dec 6, 2024

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

  • New Features

    • Introduced visual tags for navigation items: "Logs" now has a "Beta" tag, and "Success" has been updated to "Internal".
  • Bug Fixes

    • Corrected the casing of the "Internal" tag for the "Success" navigation item.

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: 4a4a825

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 5:50pm
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 5:50pm
play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 5:50pm
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 5:50pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 6, 2024

📝 Walkthrough

Walkthrough

The pull request modifies the createWorkspaceNavigation function in workspace-navigations.tsx. It introduces a new tag property for the "Logs" navigation item, which now includes a <Tag label="Beta" /> component. Additionally, the tag property for the "Success" navigation item is updated to use <Tag label="Internal" /> with a change in casing. The overall control flow and functionality remain unchanged, maintaining the existing filtering and active state logic.

Changes

File Path Change Summary
apps/dashboard/app/(app)/workspace-navigations.tsx - Added tag: <Tag label="Beta" /> for "Logs" navigation item.
- Updated tag for "Success" from <Tag label="internal" /> to <Tag label="Internal" />.

Possibly related PRs

  • fix: add copy button to log details sections #2708: The changes in this PR involve modifications to the log components, which may relate to the navigation structure in the main PR by enhancing the user interface for logs, although they do not directly alter the same functions or properties.

Suggested reviewers

  • mcstepp
  • perkinsjr
  • chronark

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between e622204 and 4a4a825.

📒 Files selected for processing (1)
  • apps/dashboard/app/(app)/workspace-navigations.tsx (1 hunks)
🔇 Additional comments (3)
apps/dashboard/app/(app)/workspace-navigations.tsx (3)

Line range hint 44-53: LGTM! Well-structured reusable Tag component.

The Tag component is well-implemented with proper TypeScript types and consistent styling, making it perfect for the new Beta tag use case.


109-109: LGTM! Consistent casing for UI labels.

The update to capitalize "Internal" in the tag label improves UI consistency.


98-103: Verify the beta feature flag implementation.

The Beta tag addition looks good and is properly gated behind the betaFeatures.logsPage flag.

Let's verify the beta feature flag implementation:

✅ Verification successful

Beta feature flag implementation is correctly used across the codebase

The betaFeatures.logsPage flag is consistently implemented:

  • Gated in navigation visibility (workspace-navigations.tsx)
  • Protected at page level (logs/page.tsx)
  • Properly defined in database schema (workspaces.ts)
  • Correctly handled in beta opt-in router (optIntoBeta.ts)
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for other uses of betaFeatures.logsPage to ensure consistent feature gating
rg "betaFeatures.logsPage" --type typescript

Length of output: 79


Script:

#!/bin/bash
# Search for betaFeatures.logsPage usage with ripgrep, without type filter
rg "betaFeatures\.logsPage"

# Also search for any logsPage feature flag references
rg "logsPage"

Length of output: 889


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants