Skip to content

chore: ratelimit curl snippets changed to -H#2644

Merged
chronark merged 1 commit intounkeyed:mainfrom
harshsbhat:harshbhat/namespace-H
Nov 6, 2024
Merged

chore: ratelimit curl snippets changed to -H#2644
chronark merged 1 commit intounkeyed:mainfrom
harshsbhat:harshbhat/namespace-H

Conversation

@harshsbhat
Copy link
Contributor

@harshsbhat harshsbhat commented Nov 5, 2024

What does this PR do?

Changed the ratelimit curl snippet to -H instead of -h

Fixes #2640

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

Not required but you can try the curl.

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

  • New Features

    • Introduced a sample curl command for API requests to the ratelimits endpoint.
    • Enhanced handling of the interval parameter to support "90d" and default to "7d".
    • Improved rendering logic for metrics, including conditional display for charts based on data availability.
  • Bug Fixes

    • Corrected header formatting in the curl command from -h to -H.
  • Refactor

    • Optimized data representation with a refined dataOverTime array.

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: b0b1490

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 1:15pm

@vercel
Copy link

vercel bot commented Nov 5, 2024

@harshsbhat is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 5, 2024

📝 Walkthrough

Walkthrough

The changes made to the RatelimitNamespacePage component in apps/dashboard/app/(app)/ratelimits/[namespaceId]/page.tsx include the introduction of a snippet variable with a corrected curl command format, updates to the handling of the interval parameter, and refinements in the rendering logic for metrics. The adjustments ensure accurate data representation and conditional rendering based on data availability, while maintaining the overall structure of the component.

Changes

Files Change Summary
apps/dashboard/app/(app)/ratelimits/[namespaceId]/page.tsx - Added a snippet variable with a corrected curl command format.
- Refined prepareInterval function to handle "90d" interval.
- Updated rendering logic for metrics and data representation.
- Implemented conditional rendering for charts based on data availability.
- Updated function signature for RatelimitNamespacePage.

Assessment against linked issues

Objective Addressed Explanation
Fix curl snippets to use -H instead of -h (#2640)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Bug Something isn't working app:dashboard Unkey dashboard related labels Nov 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@vercel vercel bot temporarily deployed to Preview – engineering November 5, 2024 13:15 Inactive
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
apps/dashboard/app/(app)/ratelimits/[namespaceId]/page.tsx (1)

132-133: LGTM! The curl header flag is now correct.

The change from -h to -H fixes the issue reported in #2640. The headers are now properly formatted using the correct curl flag.

Consider using consistent placeholder format:

-  -H 'Authorization: Bearer <UNKEY_ROOT_KEY>' \
+  -H 'Authorization: Bearer <YOUR_UNKEY_ROOT_KEY>' \

This would match the style of <USER_ID> used below.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 06cf362 and b0b1490.

📒 Files selected for processing (1)
  • apps/dashboard/app/(app)/ratelimits/[namespaceId]/page.tsx (1 hunks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:dashboard Unkey dashboard related Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ratelimit curl snippets are wrong

2 participants