chore: ratelimit curl snippets changed to -H#2644
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@harshsbhat is attempting to deploy a commit to the Unkey Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThe changes made to the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
apps/dashboard/app/(app)/ratelimits/[namespaceId]/page.tsx (1)
132-133: LGTM! The curl header flag is now correct.The change from
-hto-Hfixes the issue reported in #2640. The headers are now properly formatted using the correct curl flag.Consider using consistent placeholder format:
- -H 'Authorization: Bearer <UNKEY_ROOT_KEY>' \ + -H 'Authorization: Bearer <YOUR_UNKEY_ROOT_KEY>' \This would match the style of
<USER_ID>used below.
What does this PR do?
Changed the ratelimit curl snippet to -H instead of -h
Fixes #2640
Type of change
How should this be tested?
Not required but you can try the curl.
Checklist
Required
pnpm buildpnpm fmtconsole.logsgit pull origin mainAppreciated
Summary by CodeRabbit
New Features
curlcommand for API requests to the ratelimits endpoint.intervalparameter to support "90d" and default to "7d".Bug Fixes
curlcommand from-hto-H.Refactor
dataOverTimearray.