feat(dashboard): remove bottom error from new override form

[unrenamed]

What does this PR do?

Removes a bottom error from the "New Override" form.

Fixes #2393

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Chore (refactoring code, technical debt, workflow improvements)
• Enhancement (small improvements)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How should this be tested?

• Head over Ratelimits > Overrides page
• Fill out the required fields with valid input
• Click the "Create" button (this will activate the form validation)
• Now, put an empty string to any of the form inputs
• Notice each field reports the corresponding error itself and there is no duplicate of that error below

Checklist

Required

• Filled out the "How to test" section in this PR
• Read Contributing Guide
• Self-reviewed my own code
• Commented on my code in hard-to-understand areas
• Ran pnpm build
• Ran pnpm fmt
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

• New Features

  • Enhanced user interface by simplifying error handling in the Create New Override component.

• Bug Fixes

  • Removed aggregated error message display to streamline user experience.

• Refactor

  • Updated the onSubmit function for clearer mapping of field values.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 1ad5ef5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 30, 2024 11:16am
engineering	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 30, 2024 11:16am

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request focus on the CreateNewOverride component within the create-new-override.tsx file. The error handling logic has been streamlined by removing the aggregation of error messages, leading to the elimination of conditional rendering for these messages. The onSubmit function has been updated for clearer mapping of field values to their boolean representations. The form structure and validation mechanisms remain unchanged, and the mutation for creating a new rate limit override continues to function as before.

Changes

File Path	Change Summary
apps/dashboard/app/(app)/ratelimits/[namespaceId]/overrides/create-new-override.tsx	Simplified error handling by removing the error variable, eliminating conditional rendering of error messages, and clarified the onSubmit function's mapping of field values.

Assessment against linked issues

Objective	Addressed	Explanation
Show all errors related to multiple invalid fields individually (2393)	✅
Standardize the font size and weight for error messages (2393)	❌	No changes were made to error message styling.

Possibly related PRs

• fix: Improve errors and remove parser to get accurate toasts #2115: This PR modifies error handling logic in a similar manner by simplifying how error messages are displayed.
• fix: Deleting the override doesn't remove it from the overrides. Refreshing it will give you a client side error. #2246 #2341: This PR involves changes to the OverridePage component, which relates to the management of rate limit overrides.
• fix: reset form fields in delete dialog on reopen #2546: This PR introduces a function to reset form fields in delete dialogs, conceptually related to form management in the CreateNewOverride component.

Suggested labels

Bug, 🕹️ oss.gg, :joystick: 150 points, hacktoberfest

Suggested reviewers

• mcstepp
• chronark
• perkinsjr

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 7322cef and 1ad5ef5.

📒 Files selected for processing (1)

• apps/dashboard/app/(app)/ratelimits/[namespaceId]/overrides/create-new-override.tsx (0 hunks)

💤 Files with no reviewable changes (1)

• apps/dashboard/app/(app)/ratelimits/[namespaceId]/overrides/create-new-override.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vercel]

@unrenamed is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[oss-gg]

Awarding unrenamed: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/unrenamed