Skip to content

docs: Quest complete#2541

Closed
ShreyasLakhani wants to merge 5 commits intounkeyed:mainfrom
ShreyasLakhani:quest
Closed

docs: Quest complete#2541
ShreyasLakhani wants to merge 5 commits intounkeyed:mainfrom
ShreyasLakhani:quest

Conversation

@ShreyasLakhani
Copy link

@ShreyasLakhani ShreyasLakhani commented Oct 23, 2024

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

image
image

Summary by CodeRabbit

  • Removed Features

    • The template filtering and display functionality has been removed, eliminating the associated user interface elements.
  • Documentation Updates

    • Added a new participant entry for Shreyans Lakhani in the Unkey X account list.
    • Updated the "Starry-eyed Supporter" quest documentation with a new participant entry for Shreyas Lakhani.

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: 9a647eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 5:13am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2024

📝 Walkthrough

Walkthrough

The changes involve the deletion of a React component file client.tsx, which was responsible for rendering a user interface for filtering and displaying templates based on user-selected criteria. Additionally, two markdown documents were updated to include new entries related to participants following the Unkey X account and participation in the "Starry-eyed Supporter" side quest.

Changes

File Path Change Summary
apps/www/app/templates/client.tsx Deleted the TemplatesClient component, removing functionality for filtering and displaying templates.
oss.gg/3_follow_the_unkey_x_account.md Added entry for Shreyans Lakhani dated 23-October-2024 with a link to their X account.
oss.gg/4_starry_eyed_supporter.md Added entry for "shreyas lakhani" dated 23-October-2024 in the proof section of the document.

Possibly related PRs

Suggested reviewers

  • mcstepp
  • chronark
  • perkinsjr
  • MichaelUnkey

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel
Copy link

vercel bot commented Oct 23, 2024

@ShreyasLakhani is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (2)
oss.gg/3_follow_the_unkey_x_account.md (2)

57-57: Remove unnecessary blank line.

The extra blank line disrupts the consistent spacing between entries.

» Link to Account: https://x.com/zia_webdev
-

» 23-October-2024 by [Shreyans Lakhani](@LakhaniShreyas)

58-59: Maintain consistent URL formatting.

To maintain consistency with other entries and fix the markdownlint warning about bare URLs, consider wrapping the URL in angle brackets.

» 23-October-2024 by [Shreyans Lakhani](@LakhaniShreyas)
-» Link to Account: https://x.com/LakhaniShreyas
+» Link to Account: <https://x.com/LakhaniShreyas>
🧰 Tools
🪛 Markdownlint

59-59: null
Bare URL used

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between b456ac0 and c3f9728.

📒 Files selected for processing (3)
  • apps/www/app/templates/client.tsx (0 hunks)
  • oss.gg/3_follow_the_unkey_x_account.md (1 hunks)
  • oss.gg/4_starry_eyed_supporter.md (1 hunks)
💤 Files with no reviewable changes (1)
  • apps/www/app/templates/client.tsx
🧰 Additional context used
🪛 Markdownlint
oss.gg/3_follow_the_unkey_x_account.md

59-59: null
Bare URL used

(MD034, no-bare-urls)

@ShreyasLakhani ShreyasLakhani changed the title Quest complete docs: Quest complete Oct 23, 2024
@chronark
Copy link
Collaborator

why does this delete a file?

@ShreyasLakhani
Copy link
Author

ShreyasLakhani commented Oct 28, 2024

@chronark deleted file is related to #2432 issue and I already raised PR (delete file) which #2502. And this PR is related to quests that's why I delete.

@ShreyasLakhani
Copy link
Author

@chronark review this PR

Copy link
Collaborator

@chronark chronark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't delete files

@ShreyasLakhani
Copy link
Author

@chronark Will open new PR and closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants