Skip to content

Fix: Copy Icon Misalignment for Short Permission Names#2354

Closed
SOUMITRO-SAHA wants to merge 1 commit intounkeyed:mainfrom
SOUMITRO-SAHA:SOUMITRASAHA#2348
Closed

Fix: Copy Icon Misalignment for Short Permission Names#2354
SOUMITRO-SAHA wants to merge 1 commit intounkeyed:mainfrom
SOUMITRO-SAHA:SOUMITRASAHA#2348

Conversation

@SOUMITRO-SAHA
Copy link

@SOUMITRO-SAHA SOUMITRO-SAHA commented Oct 12, 2024

What does this PR do?

Fix the Copy Button Position for Short Text.

Fixes #2348

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

No need for testing; it's a small bug fix. I have also attached a screenshot of the final change.

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

unkey

Summary by CodeRabbit

  • Style
    • Improved readability of import statements and JSX structure in the permissions page.
    • Adjusted class names for better layout management in the PageHeader component.

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2024

⚠️ No Changeset found

Latest commit: af31053

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vercel
Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 0:49am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 12, 2024

📝 Walkthrough

Walkthrough

The changes in the pull request primarily focus on formatting and structural updates to the page.tsx file located in the apps/dashboard/app/(app)/authorization/permissions/[permissionId] directory. Key modifications include reformatting import statements for better readability and adjusting the JSX structure of components, specifically the PageHeader and Metric components. These updates enhance code maintainability without impacting functionality.

Changes

File Path Change Summary
apps/dashboard/app/(app)/authorization/permissions/[permissionId]/page.tsx Reformatted import statements and adjusted JSX structure in PageHeader and Metric components for improved readability.

Assessment against linked issues

Objective Addressed Explanation
Copy icon should remain on the right side of the permission name (#2348) The changes do not address the copy icon misalignment issue.

Possibly related PRs

  • fix: truncate long permission names with ellipses #2071: This PR modifies the page.tsx file in the same directory and enhances the user interface by integrating a tooltip feature around the permission name display, which is directly related to the changes made in the main PR regarding the TooltipTrigger component.
  • fix(dashboard): hydration warnings #2253: This PR also modifies the page.tsx file and updates the TooltipTrigger component, enhancing the layout structure by allowing a div element to wrap the content, which aligns with the structural updates made in the main PR.

Suggested labels

Bug, 🕹️ oss.gg, :joystick: 150 points, hacktoberfest

Suggested reviewers

  • chronark
  • mcstepp
  • perkinsjr

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 3c04102 and af31053.

📒 Files selected for processing (1)
  • apps/dashboard/app/(app)/authorization/permissions/[permissionId]/page.tsx (3 hunks)
✅ Files skipped from review due to trivial changes (1)
  • apps/dashboard/app/(app)/authorization/permissions/[permissionId]/page.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel
Copy link

vercel bot commented Oct 12, 2024

@SOUMITRO-SAHA is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added Bug Something isn't working Needs Approval Needs approval from Unkey labels Oct 12, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Here is an example:

<type>[optional scope]: <description>
fix: I fixed something for Unkey

Details:

Unknown release type "Fix" found in pull request title "Fix: Copy Icon Misalignment for Short Permission Names". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@chronark
Copy link
Collaborator

Closing as this was already assigned to someone else, please don't work on issues that are not assigned to you

@chronark chronark closed this Oct 14, 2024
@SOUMITRO-SAHA
Copy link
Author

When I resolved the issue, there was no one assigned to it. However, after @chronark added the OSS label, someone else used /assign and it was assigned. This feels unfair and quite discouraging!!!!

Although I have already solved the issue and raised the PR, the situation is very disappointing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Needs Approval Needs approval from Unkey

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy Icon Misalignment for Short Permission Names

3 participants