Skip to content

chore: remove tinybird imports#2217

Merged
chronark merged 1 commit intomainfrom
tinybird
Oct 5, 2024
Merged

chore: remove tinybird imports#2217
chronark merged 1 commit intomainfrom
tinybird

Conversation

@chronark
Copy link
Collaborator

@chronark chronark commented Oct 5, 2024

Summary by CodeRabbit

  • New Features

    • Simplified logging process by removing the integration with Tinybird for audit logs related to default byte size and prefix updates.
  • Bug Fixes

    • Maintained existing error handling and input validation for database transactions.

@vercel
Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 6:14pm
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 6:14pm
play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 6:14pm
workflows ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 6:14pm
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 6:14pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2024

⚠️ No Changeset found

Latest commit: 34776e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 5, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request modifies the setDefaultApiBytes and setDefaultApiPrefix functions in their respective files by removing the ingestAuditLogsTinybird function calls. This change eliminates the logging of audit information to Tinybird after updating the default byte size and prefix for API keys. The existing logic for inserting audit logs into the database remains unchanged, as does the input validation schema and error handling for database operations.

Changes

File Path Change Summary
apps/dashboard/lib/trpc/routers/api/setDefaultBytes.ts Removed ingestAuditLogsTinybird function call from setDefaultApiBytes, retaining database logging logic.
apps/dashboard/lib/trpc/routers/api/setDefaultPrefix.ts Removed ingestAuditLogsTinybird function call from setDefaultApiPrefix, retaining database logging logic.

Possibly related PRs

Suggested reviewers

  • mcstepp
  • perkinsjr

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@chronark chronark merged commit dfbfab2 into main Oct 5, 2024
@chronark chronark deleted the tinybird branch October 5, 2024 18:07
@vercel vercel bot temporarily deployed to Preview – play October 5, 2024 18:07 Inactive
@vercel vercel bot temporarily deployed to Preview – workflows October 5, 2024 18:08 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard October 5, 2024 18:13 Inactive
@vercel vercel bot temporarily deployed to Preview – engineering October 5, 2024 18:13 Inactive
@vercel vercel bot temporarily deployed to Preview – www October 5, 2024 18:14 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant