fix: only add known ignore patterns by default #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relavant issues: #265, unjs/unbuild#472
This PR replaces problematic gitignore inferences with only known patterns
["**/node_modules", "**/coverage", "**/.git"](same asglobbydefaults)Context: #253 enabled dotfiles scanning and at the same time we added a small solution to infer gitignore patterns. however, it is problematic because
tinyglobbyunlikeglobbydoes not natively has gitignore support and gitignore patterns are not same as glob patterns (#265)This PR is an alternative to #271 because even if using ignore util, we need to convert scanned paths to be relative from root before matching (which is likely to have more edge cases), we need nested gitignore support and on top of all this, it still breaks situation when it is intended to build an autogenerated and ignored file from
src.