Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkdist ignores src files #472

Closed
xsjcTony opened this issue Dec 28, 2024 · 2 comments
Closed

mkdist ignores src files #472

xsjcTony opened this issue Dec 28, 2024 · 2 comments
Labels
bug Something isn't working mkdist

Comments

@xsjcTony
Copy link

Environment

Node.js: v20.18.0
unbuild: ✅v3.0.0-rc.11 / ❌v3.0.0

Reproduction

https://github.com/xsjcTony/remark-magic-link/blob/main/package.json

Describe the bug

This is the config I'm using, however it works well (see screenshot for output) in v3.0.0-rc.11, but not in v3.0.0 (as well as v3.1.0).
No idea why.

entries: [
  'src/index',
  { input: 'src', outDir: '.', pattern: ['**/*.css'], builder: 'mkdist', loaders: ['postcss'] },
],

Snipaste_2024-12-29_01-24-25

Additional context

It may because of the upgrade of mkdist to v2, I've tried to dig into it, but unfortunately I can't find anything.

Logs

No response

@xsjcTony xsjcTony added the bug Something isn't working label Dec 28, 2024
@pi0 pi0 added the mkdist label Dec 28, 2024
@pi0
Copy link
Member

pi0 commented Dec 28, 2024

Thanks for the report. this issue comes from mkdist since we migrated from globby to tinyglobby which does not support githinore natively.

Here is a current workaround:

    { input: 'src', outDir: '.', pattern: ['**/*.css'], builder: 'mkdist', loaders: ['postcss'],
      globOptions: { ignore: [] } },

@pi0 pi0 changed the title Same usage breaks in v3.0.0 but works in v3.0.0-rc.11 mkdist ignores src files Dec 28, 2024
@pi0
Copy link
Member

pi0 commented Dec 28, 2024

Fixed in https://github.com/unjs/mkdist/releases/tag/v2.2.0

(you can use pnpm upgrade unbuild mkdist to make sure [email protected]+ is installed)

@pi0 pi0 closed this as completed Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mkdist
Projects
None yet
Development

No branches or pull requests

2 participants