Change pattern representation of fractional seconds; remove obsolete FieldLength variants #5392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
force-pushed
the
new-fractional-seconds
branch
5 times, most recently
from
381be5b
to
97e5f57
Compare
sffc
force-pushed
the
new-fractional-seconds
branch
from
97e5f57
to
36c2fea
Compare
sffc
changed the title
|
There are 2 things going on in this PR: the fractional second change, and removing obsolete FieldLength variants. They are in the same PR because I had earlier thought about supporting fractional seconds via FieldLength, but then I changed to FieldSymbol instead, which ended up being much cleaner. If you want me to cut out the FieldLength changes to their own PR, I can do that upon request. |
Manishearth
previously approved these changes
Aug 20, 2024
Manishearth
approved these changes
Aug 20, 2024
zbraniecki
reviewed
Aug 22, 2024
| #[zerovec::make_ule(DecimalSecondULE)] | ||
| #[zerovec::derive(Debug)] | ||
| #[allow(clippy::exhaustive_enums)] // used in data struct | ||
| pub enum DecimalSecond { |
There was a problem hiding this comment.
question, n-b: what's the advantage of this over DecimalSecond(u8)?
There was a problem hiding this comment.
- Can exhaustively match
- More niches
- Encodes the invariants into the type itself
zbraniecki
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1317
This makes it such that adding or removing fractional second digits involves changing one FieldSymbol, rather than going and mutating the choice of fields in the pattern. Simpler and less error-prone at runtime.
The parsing of "ss.SSS" is moved into the parser, where it belongs, rather than handling it at format time.