-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an Ideal Components Bag / Skeleton for DateTimeFormat #1317
Comments
@gregtatum will provide mentorship. |
I'm spreading the word about this issue looking for candidates. More details:
|
I'm interested to work on this issue. |
@gregtatum are you still open to mentor? |
If this issue is still open, I'm definitely interested to work on this. |
@ozghimire Great! How would you prefer to get started? There is a document linked above outlining the strategy which should discuss how to get things going. I would suggest starting with #1318. I will fill in more details on that issue. @pdogr I think ozghimire is taking the first step on this to move it forward, and it's hard to parallelize this initial step, but there will probably be work to help out on around the issues. You could take another DateTimeFormat issue to get onboarded. I'm sure there will be opportunities to help in the short term. #1581 would be a good bug to onboard with if you wanted to take it. |
Hello @gregtatum, are still looking for contributors? |
Working on the combined date/time pattern overrides. All classical skeleta across all locales and calendars in CLDR (as a comma-separated list):
Of those, the ones that span date/time/zone are: EBhm In order to keep a fixed set of auxiliary keys known at compile time, I will proceed to hard-code and generate those sets. I will store them only when they differ from the glue-based pattern. I will also open an issue to add a test that will inform us if any more such skeleta get added in the future. |
…FieldLength variants (#5392) #1317 This makes it such that adding or removing fractional second digits involves changing one FieldSymbol, rather than going and mutating the choice of fields in the pattern. Simpler and less error-prone at runtime. The parsing of "ss.SSS" is moved into the parser, where it belongs, rather than handling it at format time.
This is a meta issue to track implementing the "ideal components bag" as laid out in the DateTimeFormat Deep Dive 2021-10-01 design document. Originally there was some discussion to have this replace the current components bag, but it is to be implemented alongside the existing components bag. A better name can be bikeshed if needed.
The following need to be completed.
The text was updated successfully, but these errors were encountered: