Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.72 toolchain, 1.66 MSRV #3973

Merged
merged 6 commits into from
Aug 30, 2023
Merged

1.72 toolchain, 1.66 MSRV #3973

merged 6 commits into from
Aug 30, 2023

Conversation

robertbastian
Copy link
Member

This should be reviewed commit-by-commit.

keys: self.keys,
values: self.values,
}
*self
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine

Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ for actual changes. I wasn't sure if we had decided to do this bump, AIUI our MSRV policy was to only bump when we have a reason to, yes?

@@ -328,14 +330,14 @@ impl DataExporter for BakedExporter {
let bake = payload.tokenize(&self.dependencies);

self.write_impl_macro(quote! {
#[clippy::msrv = "1.65"]
#[clippy::msrv = #MSRV]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: clever

@robertbastian
Copy link
Member Author

This has convenience functions on BTreeSet/map that might be ... convenient.

I'm also happy to wait, but I definitely want to do 1.67 when we're allowed to, because that has ilog10.

@sffc
Copy link
Member

sffc commented Aug 30, 2023

I'd like to use core::hint::black_box in a few places, and I think there are some places where the add_unsigned functions also would be useful. Also I think rust-lang/rust#101520 shipped in 1.66 which will help us remove some unsafe in the yoke crate.

@Manishearth
Copy link
Member

that works for me!

@robertbastian robertbastian merged commit cfd9e22 into unicode-org:main Aug 30, 2023
@robertbastian robertbastian deleted the 77 branch August 30, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants