1.72 toolchain, 1.66 MSRV (#3973)

.github/workflows/build-test.yml

@@ -32,7 +32,7 @@ concurrency:
 jobs:
 
   # ci-job-check & ci-job-features
-  # Running at MSRV (1.65)
+  # Running at MSRV (1.66)
   msrv:
     runs-on: ubuntu-latest
     # Defined as a matrix so that features can start immediately, but
@@ -580,7 +580,6 @@ jobs:
 
   # ci-job-fmt
   fmt:
-    if: github.event_name != 'schedule'
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v3

Cargo.toml

@@ -115,7 +115,7 @@ exclude = [
 
 [workspace.package]
 version = "1.2.0"
-rust-version = "1.65"
+rust-version = "1.66"
 authors = ["The ICU4X Project Developers"]
 edition = "2021"
 repository = "https://github.com/unicode-org/icu4x"

Makefile.toml

@@ -61,8 +61,8 @@ description = "Run all tests for the CI 'check' job"
 category = "ICU4X Development"
 script_runner = "@duckscript"
 script = '''
-exec --fail-on-error rustup install 1.65 --profile minimal
-exec --fail-on-error cargo +1.65 check --all-targets --all-features
+exec --fail-on-error rustup install 1.66 --profile minimal
+exec --fail-on-error cargo +1.66 check --all-targets --all-features
 '''
 
 [tasks.ci-job-test]
@@ -149,26 +149,26 @@ description = "Run all tests for the CI 'msrv-features-1' job"
 category = "CI"
 script_runner = "@duckscript"
 script = '''
-exec --fail-on-error rustup install 1.65 --profile minimal
-exec --fail-on-error cargo +1.65 make check-all-features-chunked 1
+exec --fail-on-error rustup install 1.66 --profile minimal
+exec --fail-on-error cargo +1.66 make check-all-features-chunked 1
 '''
 
 [tasks.ci-job-msrv-features-2]
 description = "Run all tests for the CI 'msrv-features-2' job"
 category = "CI"
 script_runner = "@duckscript"
 script = '''
-exec --fail-on-error rustup install 1.65 --profile minimal
-exec --fail-on-error cargo +1.65 make check-all-features-chunked 2
+exec --fail-on-error rustup install 1.66 --profile minimal
+exec --fail-on-error cargo +1.66 make check-all-features-chunked 2
 '''
 
 [tasks.ci-job-msrv-features-3]
 description = "Run all tests for the CI 'msrv-features-3' job"
 category = "CI"
 script_runner = "@duckscript"
 script = '''
-exec --fail-on-error rustup install 1.65 --profile minimal
-exec --fail-on-error cargo +1.65 make check-all-features-chunked 3
+exec --fail-on-error rustup install 1.66 --profile minimal
+exec --fail-on-error cargo +1.66 make check-all-features-chunked 3
 '''
 
 [tasks.ci-job-fmt]

clippy.toml

@@ -2,4 +2,4 @@
 # called LICENSE at the top level of the ICU4X source tree
 # (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
-msrv = "1.65.0"
+msrv = "1.66.0"

components/calendar/src/persian.rs

@@ -70,8 +70,8 @@ pub struct PersianDateInner(ArithmeticDate<Persian>);
 impl CalendarArithmetic for Persian {
     fn month_days(year: i32, month: u8) -> u8 {
         match month {
-            1 | 2 | 3 | 4 | 5 | 6 => 31,
-            7 | 8 | 9 | 10 | 11 => 30,
+            1..=6 => 31,
+            7..=11 => 30,
             12 if Self::is_leap_year(year) => 30,
             12 => 29,
             _ => 0,
@@ -689,7 +689,7 @@ mod tests {
             expected_next: i32,
         }
 
-        let test_cases = vec![
+        let test_cases = [
             TestCase {
                 input: 0,
                 expected_prev: -1,

components/casemap/src/titlecase.rs

@@ -209,7 +209,9 @@ impl TitlecaseMapper<CaseMapper> {
     {
         let cm = CaseMapper::try_new_unstable(provider)?;
         let gc = icu_properties::maps::load_general_category(provider).map_err(|e| {
-            let PropertiesError::PropDataLoad(e) = e else { unreachable!() };
+            let PropertiesError::PropDataLoad(e) = e else {
+                unreachable!()
+            };
             e
         })?;
         Ok(Self { cm, gc })
@@ -250,7 +252,9 @@ impl<CM: AsRef<CaseMapper>> TitlecaseMapper<CM> {
         P: DataProvider<CaseMapV1Marker> + DataProvider<GeneralCategoryV1Marker> + ?Sized,
     {
         let gc = icu_properties::maps::load_general_category(provider).map_err(|e| {
-            let PropertiesError::PropDataLoad(e) = e else { unreachable!() };
+            let PropertiesError::PropDataLoad(e) = e else {
+                unreachable!()
+            };
             e
         })?;
         Ok(Self { cm: casemapper, gc })

components/collator/benches/bench.rs

@@ -91,7 +91,7 @@ pub fn collator_with_locale(criterion: &mut Criterion) {
     // In particular, to get full Japanese standard behavior, you need the identical strength.
     // Furthermore, CLDR used to default to quaternary for Japanese but now defaults to tertiary
     // as for every other language for performance reasons.
-    let all_strength = vec![
+    let all_strength = [
         Strength::Primary,
         Strength::Secondary,
         Strength::Tertiary,