Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch code coverage to Tarpaulin #184

Closed
wants to merge 1 commit into from

Conversation

zbraniecki
Copy link
Member

No description provided.

@zbraniecki zbraniecki requested a review from a team as a code owner July 26, 2020 22:43
@zbraniecki zbraniecki force-pushed the tarpaulin branch 2 times, most recently from 3d45f39 to 0a0dd5e Compare July 26, 2020 22:48
@coveralls
Copy link

coveralls commented Jul 26, 2020

Pull Request Test Coverage Report for Build 7f6f865efce7c61f38e0a74b5883d977a6218e77-PR-184

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 141 unchanged lines in 22 files lost coverage.
  • Overall coverage decreased (-7.9%) to 83.218%

Files with Coverage Reduction New Missed Lines %
components/data-provider-json/src/lib.rs 1 95.45%
components/locale/src/subtags/script.rs 1 88.24%
components/locale/src/subtags/variant.rs 1 90.91%
components/locale/src/subtags/region.rs 2 91.3%
components/locale/src/extensions/mod.rs 3 90.63%
components/locale/src/serde/langid.rs 3 83.33%
components/locale/src/langid.rs 5 78.26%
components/uniset/src/uniset.rs 5 95.76%
components/locale/src/extensions/private/key.rs 6 53.85%
components/locale/src/extensions/private/mod.rs 6 66.67%
Totals Coverage Status
Change from base Build 1e3b00ea3b0456993de8f1f2ee0b4cbfb90ddc7f: -7.9%
Covered Lines: 843
Relevant Lines: 1013

💛 - Coveralls

@zbraniecki
Copy link
Member Author

It was my attempt to see if switching to tarpaulin will give better coverage than grcov, but it seems that it has even more false positives.

I like tarpaulin because you can easily launch it locally with cargo tarpaulin -v and you can set #[cfg(not(tarpaulin))] to ignore a given file.
I'll keep this PR closed and re-try in some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants