-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Short-term fix to make coverage CI check pass #316
Comments
that has been merged now. |
The PR to remove caching from the CI coverage checks has been merged. Even though we thought that it would fix the immediate problem, we're currently not seeing the CI coverage checks pass. I want to keep this issue open until we get that working. |
Is there a way to run the CI checks locally? That seems to me as a necessary step to get to a place where this can be debugged effectively. |
There is nothing official. And there wasn't anything open-source worth trying, at least when I started GH Actions stuff in the summer.. It looks like, in that relatively short time, the leading community tool for this has fixed an important issue recently that makes it worth trying out. I agree, I don't understand why an important framework wouldn't have a local runner, for exactly that reason. |
I got a repro! Manually followed https://github.com/mozilla/grcov#usage until I'm going to try to fix it or switch us to tarpaulin. |
Ok, so the issue is described by Alex in rust-lang/cargo#5423 I have two ideas how to fix it:
|
fixed |
Reported upstream as mozilla/grcov#494 |
In order to immediately unblock coverage checks, we should remove caching from the coverage checks in CI. (ex: #312)
The longer-term solution is represented separately in #315.
The text was updated successfully, but these errors were encountered: