Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Short-term fix of coverage check in CI by removing caching #331

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Short-term fix of coverage check in CI by removing caching #331

merged 1 commit into from
Oct 13, 2020

Conversation

echeran
Copy link
Contributor

@echeran echeran commented Oct 11, 2020

Fixes #316

@echeran
Copy link
Contributor Author

echeran commented Oct 11, 2020

@zbraniecki I thought that the coverage CI check error would go away simply by turning off caching, on the assumption that the error message was related to different Rust versions of current source code vs. cached previously-compiled artifacts. After making that change in this PR, I still see this error:

error: the linked panic runtime `panic_unwind` is not compiled with this crate's panic strategy `abort`
Error: the linked panic runtime `panic_unwind` is not compiled with this crate's panic strategy `abort`
error: aborting due to previous error
Error: aborting due to previous error
error: could not compile `icu-locale-macros`
Error: could not compile `icu-locale-macros`

@echeran echeran force-pushed the ci-coverage-remove-cache branch from c918e0a to afb913a Compare October 12, 2020 19:00
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/coverage.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@echeran echeran force-pushed the ci-coverage-remove-cache branch from afb913a to 4233063 Compare October 13, 2020 17:00
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@echeran echeran requested review from sffc and zbraniecki October 13, 2020 17:20
@echeran echeran marked this pull request as ready for review October 13, 2020 17:20
@echeran echeran requested a review from a team as a code owner October 13, 2020 17:20
@echeran echeran merged commit 24b22c9 into unicode-org:master Oct 13, 2020
@zbraniecki zbraniecki mentioned this pull request Oct 13, 2020
Open
@echeran echeran deleted the ci-coverage-remove-cache branch October 15, 2020 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbraniecki zbraniecki zbraniecki approved these changes

@sffc sffc Awaiting requested review from sffc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Short-term fix to make coverage CI check pass
2 participants
@echeran @zbraniecki