Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17975 MessageFormat v46 Technical Preview pour #4078

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

aphillips
Copy link
Member

@aphillips aphillips commented Sep 25, 2024

CLDR-17975

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@aphillips aphillips marked this pull request as ready for review September 25, 2024 20:32
@macchiati
Copy link
Member

Ack, the commit messages were wrong.

Each one has to start with
CLDR-17975

The easiest way to fix at this point is to click on Details under "jira-ticket" above. (Direct link https://us-central1-dev-infra-273822.cloudfunctions.net/unicode-github-bot/info/unicode-org/cldr/4078). Hit [Squash Branch] which will result in a new commit message (which will start with CLDR-17975), and click " Yes, I understand. This is what I want." and [Perform Squash].

Let me know when this is done, and I'll ok it again if needed, and Merge.

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@macchiati
Copy link
Member

Looks great. I'm at the doctor's, will merge once the checks finish. Thanks

CC @AEApple

@aphillips
Copy link
Member Author

@macchiati I think we got it now. Thanks for the hint.

Note that we'd like it if the linkifier were run on the final HTML. But that's not required just now.

@AEApple
Copy link
Contributor

AEApple commented Sep 25, 2024

I'll merge since all tests have passed.

@AEApple AEApple merged commit 45e5917 into unicode-org:main Sep 25, 2024
9 checks passed
@macchiati
Copy link
Member

macchiati commented Sep 25, 2024 via email

@aphillips
Copy link
Member Author

@macchiati Note that the linkifier adds links inside our spec from terms to the definition. E.g. if it says message a link gets added to the **_<dfn>message</dfn>_** location in the spec. Other Unicode specs might benefit from this (we do a lot of auto-term linking in W3C via our tools Respec or bikeshed

@macchiati
Copy link
Member

Ah, that would be very useful for the whole LDML spec (and others) We already process for the TOC, this would be a useful addition. cc @loomis

@macchiati
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants