-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17975 MessageFormat v46 Technical Preview pour #4078
CLDR-17975 MessageFormat v46 Technical Preview pour #4078
Conversation
Ack, the commit messages were wrong. Each one has to start with The easiest way to fix at this point is to click on Details under "jira-ticket" above. (Direct link https://us-central1-dev-infra-273822.cloudfunctions.net/unicode-github-bot/info/unicode-org/cldr/4078). Hit [Squash Branch] which will result in a new commit message (which will start with CLDR-17975), and click " Yes, I understand. This is what I want." and [Perform Squash]. Let me know when this is done, and I'll ok it again if needed, and Merge. |
26acbb7
to
cec47b9
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Looks great. I'm at the doctor's, will merge once the checks finish. Thanks CC @AEApple |
@macchiati I think we got it now. Thanks for the hint. Note that we'd like it if the linkifier were run on the final HTML. But that's not required just now. |
I'll merge since all tests have passed. |
I agree. I'd recently filed
https://unicode-org.atlassian.net/browse/CLDR-17970. Ideally all spec and
site pages would have to have no broken links before they could be merged.
(or at least no broken links to other Unicode pages.
…On Wed, Sep 25, 2024 at 4:02 PM Annemarie Apple ***@***.***> wrote:
Merged #4078 <#4078> into main.
—
Reply to this email directly, view it on GitHub
<#4078 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMCLLY2S3UIXCCLCPH3ZYM6GXAVCNFSM6AAAAABO3GUJRWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGQYDMOJTG4YDGMQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@macchiati Note that the linkifier adds links inside our spec from terms to the definition. E.g. if it says message a link gets added to the |
Ah, that would be very useful for the whole LDML spec (and others) We already process for the TOC, this would be a useful addition. cc @loomis |
CLDR-17975
ALLOW_MANY_COMMITS=true