Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17949 hotfix for random ICU timezone breakage #4050

Merged
merged 1 commit into from
Sep 13, 2024
Merged

CLDR-17949 hotfix for random ICU timezone breakage #4050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestSupplementalInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2032,6 +2032,10 @@ public void TestMetazones() {
ImmutableSet.of("America/Montreal", "Asia/Barnaul", "Asia/Tomsk", "Europe/Kirov");
for (String timezoneRaw : TimeZone.getAvailableIDs()) {
String timezone = TimeZone.getCanonicalID(timezoneRaw);
if (timezone.equals("Etc/Unknown")) {
System.err.println("CLDR-17949: Skipping " + timezone + " for raw " + timezoneRaw);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we do this with logKnownIssue? But approving anyway to get things unblocked.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, yes, but was just trying to get unblocked

continue;
}
String region = TimeZone.getRegion(timezone);
if (!timezone.equals(timezoneRaw) || "001".equals(region)) {
continue;
Expand Down
Loading