CLDR-17949 hotfix for random ICU timezone breakage #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
requested review from
yumaoka,
macchiati,
AEApple,
btangmu,
pedberg-icu and
DraganBesevic
pedberg-icu
reviewed
Sep 13, 2024
| @@ -2032,6 +2032,10 @@ public void TestMetazones() { | |||
| ImmutableSet.of("America/Montreal", "Asia/Barnaul", "Asia/Tomsk", "Europe/Kirov"); | |||
| for (String timezoneRaw : TimeZone.getAvailableIDs()) { | |||
| String timezone = TimeZone.getCanonicalID(timezoneRaw); | |||
| if (timezone.equals("Etc/Unknown")) { | |||
| System.err.println("CLDR-17949: Skipping " + timezone + " for raw " + timezoneRaw); | |||
There was a problem hiding this comment.
Shouldn't we do this with logKnownIssue? But approving anyway to get things unblocked.
There was a problem hiding this comment.
Ideally, yes, but was just trying to get unblocked
pedberg-icu
approved these changes
Sep 13, 2024
|
Can't merge yet, tests not finished, and I am done for the evening |
|
Actually I was able to merge |
haytenf
pushed a commit
to haytenf/cldr
that referenced
this pull request
Sep 17, 2024
conradarcturus
pushed a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17949
ICU is returning random zones that don't resolve… work around it so CLDR can merge PRs…
ALLOW_MANY_COMMITS=true