CLDR-15649 Dashboard using filters, show spinner while updating visibility #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See comments in #3640 |
btangmu
commented
May 1, 2024
| <a-spin size="large" /> | ||
| </template> | ||
| <template v-else> | ||
| <template |
There was a problem hiding this comment.
changed lines below in this template are just indented one more level
srl295
previously approved these changes
May 1, 2024
srl295
reviewed
May 1, 2024
…ility -The spinner replaces the Dashboard rows until Vue updates the DOM to reflect checkbox change -Format cldrErrorSubtypes.mjs (from another ticket)
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
@srl295 I implemented your suggested spinner delay and this is ready for review again |
macchiati
approved these changes
May 2, 2024
srl295
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-The spinner replaces the Dashboard rows until Vue updates the DOM to reflect checkbox change
-Format cldrErrorSubtypes.mjs (from another ticket)
CLDR-15649
ALLOW_MANY_COMMITS=true