Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-15649 Dashboard using filters #3640

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented Apr 17, 2024

-Add checkbox next to each notification category in Dashboard header

-The category is hidden if the checkbox is unchecked

-Error and Missing notifications still cannot be hidden with pre-existing right-side path-specific checkboxes, but they can be hidden categorically using the new checkboxes

-Show each path with notifications only once in Dashboard

-If a path has more than one notification, combine them on one line

-Perform data conversion on the front end; http response still has multiple notifications per path

-Refactor to avoid http code in Vue; call cldrAjax.mjs from cldrDash.mjs not from DashboardWidget.vue

-New classes DashData and DashEntry in cldrDash.mjs

-Use new method dashData.addEntriesFromJson for both whole-page json and single-path json

-Make hover titles clearer for circled abbreviations like EC for English Changed

-As before, always hide Abstained notifications if user is TC, but implement on the back end instead of the front end (simpler and more efficient)

-Update and extend the unit test TestCldrDash.mjs, since DashData is now different format from json

-Turn off debug-logging in cldrTable (CLDR_TABLE_DEBUG) and cldrVote (CLDR_VOTE_DEBUG)

CLDR-15649

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

-Add checkbox next to each notification category in Dashboard header

-The category is hidden if the checkbox is unchecked

-Error and Missing notifications still cannot be hidden with pre-existing right-side path-specific checkboxes, but they can be hidden categorically using the new checkboxes

-Show each path with notifications only once in Dashboard

-If a path has more than one notification, combine them on one line

-Perform data conversion on the front end; http response still has multiple notifications per path

-Refactor to avoid http code in Vue; call cldrAjax.mjs from cldrDash.mjs not from DashboardWidget.vue

-New classes DashData and DashEntry in cldrDash.mjs

-Use new method dashData.addEntriesFromJson for both whole-page json and single-path json

-Make hover titles clearer for circled abbreviations like EC for English Changed

-As before, always hide Abstained notifications if user is TC, but implement on the back end instead of the front end (simpler and more efficient)

-Turn off debug-logging in cldrTable (CLDR_TABLE_DEBUG) and cldrVote (CLDR_VOTE_DEBUG)
@btangmu btangmu self-assigned this Apr 17, 2024
-Add checkbox next to each notification category in Dashboard header

-The category is hidden if the checkbox is unchecked

-Error and Missing notifications still cannot be hidden with pre-existing right-side path-specific checkboxes, but they can be hidden categorically using the new checkboxes

-Show each path with notifications only once in Dashboard

-If a path has more than one notification, combine them on one line

-Perform data conversion on the front end; http response still has multiple notifications per path

-Refactor to avoid http code in Vue; call cldrAjax.mjs from cldrDash.mjs not from DashboardWidget.vue

-New classes DashData and DashEntry in cldrDash.mjs

-Use new method dashData.addEntriesFromJson for both whole-page json and single-path json

-Make hover titles clearer for circled abbreviations like EC for English Changed

-As before, always hide Abstained notifications if user is TC, but implement on the back end instead of the front end (simpler and more efficient)

-Update and extend the unit test TestCldrDash.mjs, since DashData is now different format from json

-Turn off debug-logging in cldrTable (CLDR_TABLE_DEBUG) and cldrVote (CLDR_VOTE_DEBUG)
@btangmu btangmu marked this pull request as ready for review April 23, 2024 16:13
@btangmu btangmu requested a review from srl295 April 23, 2024 16:13
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@btangmu btangmu merged commit a5c9262 into unicode-org:main Apr 29, 2024
11 checks passed
@btangmu btangmu deleted the t15649_c branch April 29, 2024 17:47
@macchiati
Copy link
Member

macchiati commented Apr 29, 2024 via email

@btangmu
Copy link
Member Author

btangmu commented Apr 30, 2024

@macchiati "Two things" -- 1. The response to clicking a checkbox takes about a second when I test it, and you're right it ought to update immediately at least to show the current checkbox state even if updating all the rows might take a second. I'll investigate that.
2. The buttons serve the important function of scrolling to the first row matching the notification category, so I wouldn't say they're "really [just] labels" now. Unless you disagree that the ability to scroll to the first matching row is important, it seems like they need to remain buttons. About placement of category names in relation to checkboxes, regardless of whether the names are buttons or labels, the convention I'm familiar with is that a checkbox should be to the left of its descriptive text -- see https://uxpickle.com/should-checkbox-labels-be-to-the-right-or-the-left/ -- what would be a counter-example in common usage?

@btangmu
Copy link
Member Author

btangmu commented Apr 30, 2024

@macchiati Here's a PR to fix the first thing, checkbox update speed: #3662

The checkbox now updates as soon as clicked. It may still take a second for the rows to refresh. There could be additional visual feedback to show that's in progress, however it might be more distracting than helpful...

@macchiati
Copy link
Member

macchiati commented May 1, 2024 via email

srl295 added a commit to srl295/cldr that referenced this pull request May 21, 2024
- fix parameters to sheet construction
- refactor XLS sheet and file calculation
- unicode-org#3640 restructured some of the front-end data
srl295 added a commit to srl295/cldr that referenced this pull request May 21, 2024
- fix parameters to sheet construction
- refactor XLSX sheet and file calculation
- unicode-org#3640 restructured some of the front-end data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants