Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17042 adjust coverage #3230

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

macchiati
Copy link
Member

@macchiati macchiati commented Aug 29, 2023

CLDR-17042

common/main/yi_UA.xml

  • Change Yiddish to be UA (001 is only for constructed languages)

common/properties/coverageLevels.txt

  • After these changes, some coverage increases

common/supplemental/coverageLevels.xml

  • Remove the new locales from those required for Basic.
  • Note: used MinimizeRegex.java to reformat the regex as a flat list, for ease of editing. If you want to look at the before and after, you can use that with the previous value to see differences.

common/supplemental/likelySubtags.xml

  • Yiddish was failing because only constructed languages are allowed to have 001 (currently)

common/supplemental/supplementalData.xml

  • Add values for tok and vo
  • Change default contents for Yiddish

common/supplemental/supplementalMetadata.xml

  • Change Yiddish to be UA (001 is only for constructed languages)

tools/cldr-code/src/main/java/org/unicode/cldr/util/CoreCoverageInfo.java

  • Added note

tools/cldr-code/src/main/java/org/unicode/cldr/util/SupplementalDataInfo.java

  • The logic was wrong, causing no to fail. Need to avoid truncation parents

tools/cldr-code/src/main/resources/org/unicode/cldr/util/data/Locales.txt

  • Update Locales.txt to reflect locales with dedicated resources (thus setting to and qu to more realistic values)

tools/cldr-code/src/test/java/org/unicode/cldr/unittest/LocaleMatcherTest.java

  • Fix Yiddish

tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestCoverage.java

  • Clean up TestLocales to actually fail when a locale is not Core, thus preventing future non-core locales

tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestCoverageLevel.java

  • Clean up test to exclude new basic
  • Also reformatted for maintenance

tools/cldr-code/src/test/java/org/unicode/cldr/unittest/XLocaleMatcherTest.java

  • Fix Yiddish

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@macchiati
Copy link
Member Author

@btangmu The extra code that the charts call to check supplemental items that the locale is missing is

CoreCoverageInfo.getCoreCoverageInfo(testFile, errors);
You can unpack the errors to find the path that failed. You can used this to have the ST match the charts. Let me know if you have questions

@macchiati macchiati marked this pull request as draft August 29, 2023 04:11
@macchiati
Copy link
Member Author

Draft for now; need to track down some errors

@macchiati macchiati marked this pull request as ready for review August 29, 2023 18:04
@macchiati
Copy link
Member Author

Now ready for review and approval

Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Need to revisit next time re: policies but LGTM for now

Comment on lines +510 to +515
"(" // start
+ "nds_NL|fa_AF|ro_MD|sr_ME|sw_CD"
// Length 4
+ "|root"
// Length 3
+ "|ace|ach|ada|ady|aeb|afh|agq|ain|akk|akz|ale|aln|alt|ang|ann|anp|apc|arc|arn|aro|arp|arq|ars|arw|ary|arz|asa|ase|atj|avk|awa"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's… the point of this?

@macchiati macchiati merged commit cf6f986 into unicode-org:main Aug 29, 2023
7 checks passed
@macchiati macchiati deleted the CLDR-17042-Adjust-coverage branch August 29, 2023 21:56
srl295 added a commit to DavidLRowe/cldr that referenced this pull request Apr 20, 2024
- leftover questions from unicode-org#3230 CLDR-17042 remain
@srl295 srl295 mentioned this pull request Apr 20, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants