-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-15253 Unicode 15 new scripts & script metadata #1668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I'm not familiar with Kawi or Nag Mundari so recommend waiting for more reviewers
Happy new year! FYI: The LSR was actually updated with three new script codes on dec24, not dec22. I assume that it's ok that this minor difference from the official data will be erased next time the whole file is ingested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I saw this, but wasn't familliar with the U15 scripts themselves.
da50ea8
to
5fde87b
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Thanks, I did the required squash. Please re-approve. |
Thanks @srl295 -- for using these scripts+data in the Unicode Tools, we need to do a mini CLDR release and update some config file in the unicodetools, right? |
CLDR-15253
Updated according to https://cldr.unicode.org/development/updating-codes/updating-script-metadata
For comparison, see PR #1291 for Unicode 14.
The public language-subtag-registry does not yet have the two new scripts.
I cherry-picked them from their dec08 registration forms, and set dec22 (+2 weeks) as preliminary addition dates.
Note that some of the tools made some changes in generated files that are not related to the two new scripts.
Apparently these tools have not been run since their code or their input data changed.
Some of these unrelated changes caused test failures, and I manually reverted them.