Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-15253 Unicode 15 new scripts & script metadata #1668

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

markusicu
Copy link
Member

CLDR-15253

  • This PR completes the ticket.

Updated according to https://cldr.unicode.org/development/updating-codes/updating-script-metadata
For comparison, see PR #1291 for Unicode 14.

The public language-subtag-registry does not yet have the two new scripts.
I cherry-picked them from their dec08 registration forms, and set dec22 (+2 weeks) as preliminary addition dates.

Note that some of the tools made some changes in generated files that are not related to the two new scripts.
Apparently these tools have not been run since their code or their input data changed.

Some of these unrelated changes caused test failures, and I manually reverted them.

btangmu
btangmu previously approved these changes Dec 18, 2021
Copy link
Member

@btangmu btangmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm not familiar with Kawi or Nag Mundari so recommend waiting for more reviewers

@markusicu
Copy link
Member Author

Happy new year!
Would anyone familiar enough with script metadata please review this after the holidays?

FYI: The LSR was actually updated with three new script codes on dec24, not dec22. I assume that it's ok that this minor difference from the official data will be erased next time the whole file is ingested.

srl295
srl295 previously approved these changes Jan 3, 2022
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I saw this, but wasn't familliar with the U15 scripts themselves.

common/supplemental/likelySubtags.xml Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@markusicu
Copy link
Member Author

Thanks, I did the required squash. Please re-approve.

@markusicu markusicu merged commit d59ca32 into unicode-org:main Jan 4, 2022
@markusicu markusicu deleted the uni15-script-meta branch January 4, 2022 17:23
@markusicu
Copy link
Member Author

Thanks @srl295 -- for using these scripts+data in the Unicode Tools, we need to do a mini CLDR release and update some config file in the unicodetools, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants