CLDR-14801 Unicode 14 new scripts & script metadata #1291
Conversation
markusicu
requested review from
srl295,
JCEmmons,
yumaoka,
btangmu and
pedberg-icu
| @@ -382,17 +382,17 @@ public void TestCoverageCompleteness() { | |||
|
|
|||
| final Pattern script100 = PatternCache.get("(" | |||
There was a problem hiding this comment.
why is this a static list? should be pulled from data (maybe lstreg?)
There was a problem hiding this comment.
Good question. I noted this in the instructions a few years ago but never investigated. See point 11 there:
- Add the script codes to TestCoverageLevel.java variable script100.
- Why is this hardcoded here? Why does it not come from common/supplemental/coverageLevels.xml?
Thinking for a moment, I guess it can't pull it from coverageLevels.xml because that's what it wants to test, and while we can get the full list of script codes from ScriptMetadata, there is no other source for the coverage levels. But maybe we could get "all others" and test against those here? @macchiati
I plan to merge this PR now, but we could revisit this.
There was a problem hiding this comment.
Good question. I noted this in the instructions a few years ago but never investigated. See point 11 there:
Add the script codes to TestCoverageLevel.java variable script100.
- Why is this hardcoded here? Why does it not come from common/supplemental/coverageLevels.xml?
Thinking for a moment, I guess it can't pull it from coverageLevels.xml because that's what it wants to test, and while we can get the full list of script codes from ScriptMetadata, there is no other source for the coverage levels. But maybe we could get "all others" and test against those here? @macchiati
It could check locale validity against coverage levels perhaps?
There was a problem hiding this comment.
FTR This variable should normally not need to be updated any more after #1296
CLDR-14801
Note: I selectively copied some scripts from the latest language-subtag-registry (File-Date: 2021-05-11) but did not update the whole file, in order to avoid having to make changes for new language subtags etc.
I updated http://cldr.unicode.org/development/updating-codes/updating-script-metadata to match what I did, adjusting paths, simplifying instructions for VM arguments, and some other details.