Add command to download and cache lists. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhobbs
commented
Oct 28, 2021
| } | ||
|
|
||
| root := parser.ParseIndex(fetched) | ||
| urls := getAllChildrenURLs(root.GetChildren()) |
There was a problem hiding this comment.
From what I could tell, only the root level awesome list has links to other lists. Is that correct? If not, how can I differentiate list links from regular link nodes?
There was a problem hiding this comment.
Yes, this is correct. The cli totally relies on this. Because, the owner of awesome list root repo pushes it with contribution guideline.
umutphp
requested changes
Oct 29, 2021
6 tasks
|
Since you merged #19 I rebased and typos should be good now 👍 |
umutphp
approved these changes
Oct 29, 2021
|
@jmhobbs Many thanks for this great PR :) |
|
My pleasure, it's a neat project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a pass at #4, would love to iterate on this if you have feedback.
Here's a demo run starting with a mostly complete cache: